From mboxrd@z Thu Jan 1 00:00:00 1970 From: jim miro Subject: Re: error compiling kvm-72 not there with kvm-69 - link kernel 2.6.26 Date: Thu, 7 Aug 2008 00:02:30 -0700 (PDT) Message-ID: <525618.60798.qm@web39507.mail.mud.yahoo.com> Reply-To: daliroot@yahoo.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE To: kvm@vger.kernel.org Return-path: Received: from web39507.mail.mud.yahoo.com ([209.191.106.91]:44551 "HELO web39507.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754120AbYHGHCd convert rfc822-to-8bit (ORCPT ); Thu, 7 Aug 2008 03:02:33 -0400 Sender: kvm-owner@vger.kernel.org List-ID: the patch does not work... watermod@miro:~/KVM$ sh run_c_kvm Message from syslogd@miro at Thu Aug 7 01:58:37 2008 ... miro kernel: Oops: 0011 [1] SMP=20 Message from syslogd@miro at Thu Aug 7 01:58:37 2008 ... miro kernel: Code: 00 00 00 00 00 00 00 00 00 00 00 20 5d ed 6e 00 81 f= f ff 20 5d ed 6e 00 81 ff ff 00 00 00 00 00 00 00 00 40 5e 9f 68 00 81 = ff ff <40> 5d ed 6e 00 81 ff ff 40 5d ed 6e 00 81 ff ff 80 e7 82 7b 00=20 Message from syslogd@miro at Thu Aug 7 01:58:37 2008 ... miro kernel: CR2: ffff81006eed5d40 Message from syslogd@miro at Thu Aug 7 01:58:37 2008 ... miro kernel: Oops: 0000 [2] SMP=20 Message from syslogd@miro at Thu Aug 7 01:58:37 2008 ... miro kernel: Code: 5f e9 91 b4 11 00 41 57 4c 8d 7f 04 41 56 41 55 41 5= 4 55 48 89 fd 4c 89 ff 4c 8d 75 08 53 48 83 ec 08 e8 6e b3 11 00 48 89 = 04 24 <48> 8b 4d 08 c7 45 00 00 00 00 00 4c 39 f1 0f 84 be 00 00 00 45=20 Message from syslogd@miro at Thu Aug 7 01:58:37 2008 ... miro kernel: CR2: 0000000000000009 --- On Thu, 8/7/08, jim miro wrote: > From: jim miro > Subject: Re: error compiling kvm-72 not there with kvm-69 - link kern= el 2.6.26 > To: kvm@vger.kernel.org > Date: Thursday, August 7, 2008, 1:46 AM > If I remove the "flags" parameter from the call to > anon_inode_getfd in the function kvm_anon_inode_getfd=20 > It compiles but I get a warning. >=20 > CC [M] /usr/src/kvm-72/kernel/anon_inodes.o > /usr/src/kvm-72/kernel/anon_inodes.c: In function > =E2=80=98kvm_anon_inode_getfd=E2=80=99: > /usr/src/kvm-72/kernel/anon_inodes.c:254: warning: passing > argument 2 of =E2=80=98anon_inode_getfd=E2=80=99 from incompatible > pointer type > CC [M] /usr/src/kvm-72/kernel/irq.o >=20 > So... > its late and I won't have time to try it tonight but > there is a coding error there. >=20 > #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,26) >=20 > int kvm_anon_inode_getfd(const char *name, > const struct file_operations *fops, > void *priv, int flags) > { > int r; > int fd; > struct inode *inode; > struct file *file; >=20 > r =3D anon_inode_getfd(&fd, &inode, &file, name, > fops, priv); > if (r < 0) > return r; > return fd; > } >=20 > #else >=20 > int kvm_anon_inode_getfd(const char *name, > const struct file_operations *fops, > void *priv, int flags) > { > return anon_inode_getfd(name, &fops, priv, flags); > } ^^^error >=20 >=20 > #endif =20