From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
Cc: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>,
Hadar Hen Zion <hadarh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 00/10] IB/core: more fixes for create_flow uverbs (for v3.12)
Date: Thu, 10 Oct 2013 12:01:48 +0300 [thread overview]
Message-ID: <52566CFC.3010802@mellanox.com> (raw)
In-Reply-To: <f0f946728cbed9458c6b641fe96f241a-zgzEX58YAwA@public.gmane.org>
On 10/10/2013 11:32, Yann Droneaud wrote:
> Le 10.10.2013 10:02, Or Gerlitz a écrit :
>> On 10/10/2013 00:12, Yann Droneaud wrote:
>>> I've suggested reverting temporarily commit 22878db, 436f2ad, 400dbc9
>>> for v3.12 in a previous message [1]. This proposition doesn't sound
>>> acceptable for Or.
>>>
>>> So I continue to improve them to be in a better shape for v3.12.
>>
>> Yan, we are 3-4 days before rc5 and as such renaming/beautifying
>> things or removing checks for negative values
>> against unsigned variables et al cleanups are not acceptable. You need
>> to re-arrange the series such that ONLY the fixes
>> to the user/kernel API are targeted to 3.12 and appear as the first
>> 2-3 patches, the rest will go to 3.13 subject to review.
>>
>
> It does not only "beautifying" the code: it actually fix it.
IB/core: Rename 'flow' structs to match other uverbs structs
IB/core: Makes uverbs flow structure using names more similar to verbs ones
IB/core: Remove checks for negative values in create_flow uverbs
You must agree that these three patches can go to 3.13 -- also, if there are
other small fixes which do not touch the user/kernel API they can go to
3.13
too and subject to review into -stable
What you need to prepare for 3.12 are fixes that relate to user/kernel API
and are not fixed in the patch Matan sent on Sep 22nd
https://patchwork.kernel.org/patch/2924341
and relative to that patch
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-10 9:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 21:12 [PATCH 00/10] IB/core: more fixes for create_flow uverbs (for v3.12) Yann Droneaud
[not found] ` <cover.1381351016.git.ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
2013-10-09 21:12 ` [PATCH 01/10] IB/core: Rename 'flow' structs to match other uverbs structs Yann Droneaud
2013-10-09 21:12 ` [PATCH 02/10] IB/core: Makes uverbs flow structure using names more similar to verbs ones Yann Droneaud
2013-10-09 21:12 ` [PATCH 03/10] IB/core: Don't include command size in uverbs create_flow Yann Droneaud
2013-10-09 21:12 ` [PATCH 04/10] IB/core: Allocate memory only for flow_spec in create_flow uverbs Yann Droneaud
2013-10-09 21:12 ` [PATCH 05/10] IB/core: Remove checks for negative values " Yann Droneaud
2013-10-09 21:12 ` [PATCH 06/10] IB/core: Check against uverbs structure size while parsing flow_spec Yann Droneaud
2013-10-09 21:12 ` [PATCH 07/10] IB/core: Uses a common header for uverbs flow_specs Yann Droneaud
2013-10-09 21:12 ` [PATCH 08/10] IB/core: Use flow_spec common header in uverbs flow_spec conversion function Yann Droneaud
2013-10-09 21:12 ` [PATCH 09/10] IB/core: Remove ib_uverbs_flow_spec structure from userspace Yann Droneaud
2013-10-09 21:12 ` [PATCH 10/10] IB/core: Add proper bound checking in flow_spec uverbs conversion to verbs Yann Droneaud
2013-10-10 8:02 ` [PATCH 00/10] IB/core: more fixes for create_flow uverbs (for v3.12) Or Gerlitz
[not found] ` <52565F28.8010008-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-10 8:32 ` Yann Droneaud
[not found] ` <f0f946728cbed9458c6b641fe96f241a-zgzEX58YAwA@public.gmane.org>
2013-10-10 9:01 ` Or Gerlitz [this message]
[not found] ` <52566CFC.3010802-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-10 9:18 ` Yann Droneaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52566CFC.3010802@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=hadarh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org \
--cc=ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.