From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Fantoni Subject: Re: [PATCH] libxl: new parameters for upstream qemu's vga interfaces Date: Thu, 10 Oct 2013 11:26:44 +0200 Message-ID: <525672D4.709@m2r.biz> References: <1380535957-4379-1-git-send-email-fabio.fantoni@m2r.biz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1380535957-4379-1-git-send-email-fabio.fantoni@m2r.biz> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Fabio Fantoni Cc: George.Dunlap@eu.citrix.com, xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com, Ian.Campbell@citrix.com, Stefano.Stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Il 30/09/2013 12:12, Fabio Fantoni ha scritto: > Change the qemu parameters for upstream qemu vgas to the > new ones (-device), introduced some years ago. Ping > > Signed-off-by: Fabio Fantoni > --- > tools/libxl/libxl_dm.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index 43c3bec..2c6f5d9 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -486,15 +486,13 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc, > > switch (b_info->u.hvm.vga.kind) { > case LIBXL_VGA_INTERFACE_TYPE_STD: > - flexarray_vappend(dm_args, "-vga", "std", NULL); > + flexarray_append_pair(dm_args, "-device", "VGA"); > break; > case LIBXL_VGA_INTERFACE_TYPE_CIRRUS: > - flexarray_vappend(dm_args, "-vga", "cirrus", NULL); > - if (b_info->video_memkb) { > - flexarray_vappend(dm_args, "-global", > - GCSPRINTF("vga.vram_size_mb=%d", > - libxl__sizekb_to_mb(b_info->video_memkb)), NULL); > - } > + flexarray_append_pair(dm_args, "-device", "cirrus-vga"); > + flexarray_append_pair(dm_args, "-global", > + GCSPRINTF("vga.vram_size_mb=%d", > + libxl__sizekb_to_mb(b_info->video_memkb))); > break; > } >