From: Archit Taneja <archit@ti.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "bcousson@baylibre.com" <bcousson@baylibre.com>,
"tony@atomide.com" <tony@atomide.com>,
"tomi.valkeinen@ti.com" <tomi.valkeinen@ti.com>,
"robdclark@gmail.com" <robdclark@gmail.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Andy Gross <andygro@gmail.com>
Subject: Re: [PATCH v3 1/2] arm: dts: omap4+: Add DMM bindings
Date: Thu, 10 Oct 2013 16:06:03 +0530 [thread overview]
Message-ID: <52568313.5070600@ti.com> (raw)
In-Reply-To: <20131010100833.GF26954@e106331-lin.cambridge.arm.com>
Hi,
On Thursday 10 October 2013 03:38 PM, Mark Rutland wrote:
> On Thu, Oct 10, 2013 at 07:36:33AM +0100, Archit Taneja wrote:
>> Add Dynamic Memory Manager (DMM) bindings for OMAP4 and OMAP5 devices. DMM
>> only requires address and irq information.
>>
>> Add documentation for the DMM bindings.
>>
>> Originally worked on by Andy Gross <andygro@gmail.com>
>>
>> Cc: Andy Gross <andygro@gmail.com>
>> Signed-off-by: Archit Taneja <archit@ti.com>
>> ---
>> Documentation/devicetree/bindings/arm/omap/dmm.txt | 16 ++++++++++++++++
>> arch/arm/boot/dts/omap4.dtsi | 7 +++++++
>> arch/arm/boot/dts/omap5.dtsi | 7 +++++++
>> 3 files changed, 30 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/arm/omap/dmm.txt
>>
>> diff --git a/Documentation/devicetree/bindings/arm/omap/dmm.txt b/Documentation/devicetree/bindings/arm/omap/dmm.txt
>> new file mode 100644
>> index 0000000..6fc3d79
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/omap/dmm.txt
>> @@ -0,0 +1,16 @@
>> +OMAP Dynamic Memory Manager (DMM) bindings
>
> Is there any documentation? A brief description of what this is would be
> nice.
I'll do that.
>
>> +
>> +Required properties:
>> +- compatible: Must be "ti,omap4-dmm" for OMAP4 family
>> + Must be "ti,omap5-dmm" for OMAP5 and DRA7x family
>
> s/must be/should contain/
>
>> +- reg: Contains timer register address range (base address and length)
>
> Huh? What's a timer got to do with the DMM?
Err, my mistake!
>
>> +- interrupts: Contains interrupt information (source, etc) for the DMM IRQ
>
> Is there a single interrupt? If so:
>
> - interrupts: Should contain an interrupt-specifier for the DMM IRQ.
Okay.
>
> Assuming the "DMM IRQ" is well defined. If there's a name for it in
> documentation, using that's preferable. If a future revision may have
> multiple interrupts, please use interrupt-names now to save us endless
> pain in future.
The IRQ is called DMM_IRQ in the documentation. I don't think there
would be more than one interrupt line from this IP. I'll still cross check.
Thanks,
Archit
next prev parent reply other threads:[~2013-10-10 10:36 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 9:14 [PATCH 0/4] arm: omap: DMM DT adaptation Archit Taneja
2013-09-13 9:14 ` [PATCH 1/4] arm: omap: display: Create omapdrm inside omap_display_init Archit Taneja
[not found] ` <1379063679-4869-2-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-13 9:24 ` Tomi Valkeinen
2013-09-13 9:38 ` Archit Taneja
[not found] ` <5232DCFE.5050700-l0cyMroinI0@public.gmane.org>
2013-09-13 9:39 ` Archit Taneja
[not found] ` <5232DD53.3010706-l0cyMroinI0@public.gmane.org>
2013-09-13 9:48 ` Tomi Valkeinen
[not found] ` <5232DF61.6000109-l0cyMroinI0@public.gmane.org>
2013-09-13 9:51 ` Archit Taneja
2013-09-13 10:02 ` Tomi Valkeinen
2013-09-13 10:17 ` Archit Taneja
2013-09-13 10:24 ` Tomi Valkeinen
[not found] ` <5232E7E2.7050606-l0cyMroinI0@public.gmane.org>
2013-09-13 10:32 ` Archit Taneja
2013-09-13 9:42 ` Tomi Valkeinen
[not found] ` <1379063679-4869-1-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-13 9:14 ` [PATCH 2/4] ARM: dts: OMAP4+: Add DMM bindings Archit Taneja
2013-09-13 9:14 ` [PATCH 3/4] drm: omap: Enable DT support for DMM Archit Taneja
[not found] ` <1379063679-4869-4-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-13 14:14 ` Rob Clark
[not found] ` <CAF6AEGu7eRFhrQZUD-43AOHNQtRWeyxYga1dnir=qUo1mQ9ebA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-16 6:28 ` Archit Taneja
[not found] ` <5236A503.90507-l0cyMroinI0@public.gmane.org>
2013-09-16 11:56 ` Rob Clark
2013-09-13 9:14 ` [PATCH 4/4] arm: omap: display: Don't build device " Archit Taneja
[not found] ` <1379063679-4869-5-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-13 9:29 ` Tomi Valkeinen
2013-09-16 9:30 ` [PATCH v2 0/2] DMM DT adaptation Archit Taneja
2013-09-16 9:30 ` [PATCH v2 1/2] arm: dts: omap4+: Add DMM bindings Archit Taneja
2013-09-16 11:19 ` Tomi Valkeinen
[not found] ` <5236E940.9070503-l0cyMroinI0@public.gmane.org>
2013-09-16 12:25 ` Archit Taneja
2013-09-16 9:30 ` [PATCH v2 2/2] drm: omap: Enable DT support for DMM Archit Taneja
[not found] ` <1379323815-14130-1-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-16 11:30 ` [PATCH v2 0/2] DMM DT adaptation Tomi Valkeinen
2013-10-10 6:36 ` [PATCH v3 " Archit Taneja
2013-10-10 6:36 ` [PATCH v3 1/2] arm: dts: omap4+: Add DMM bindings Archit Taneja
2013-10-10 10:08 ` Mark Rutland
2013-10-10 10:36 ` Archit Taneja [this message]
2013-10-10 6:36 ` [PATCH v3 2/2] drm: omap: Enable DT support for DMM Archit Taneja
2013-10-15 7:04 ` [PATCH v4 0/2] DMM DT adaptation Archit Taneja
2013-10-15 7:04 ` [PATCH v4 1/2] arm: dts: omap4+: Add DMM bindings Archit Taneja
2014-03-11 7:15 ` Tomi Valkeinen
2014-03-11 8:14 ` Archit Taneja
2013-10-15 7:04 ` [PATCH v4 2/2] drm: omap: Enable DT support for DMM Archit Taneja
2013-11-01 0:40 ` Mark Rutland
2013-11-05 5:50 ` Archit Taneja
2013-12-17 10:02 ` [PATCH v5 0/2] DMM DT adaptation Archit Taneja
2013-12-17 10:02 ` [PATCH v5 1/2] arm: dts: omap4+: Add DMM bindings Archit Taneja
2014-03-02 19:53 ` Benoit Cousson
2013-12-17 10:02 ` [PATCH v5 2/2] drm: omap: Enable DT support for DMM Archit Taneja
2014-01-03 12:34 ` [PATCH v5 0/2] DMM DT adaptation Archit Taneja
2014-01-17 7:32 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52568313.5070600@ti.com \
--to=archit@ti.com \
--cc=andygro@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robdclark@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.