From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUFAl-0006Th-ID for qemu-devel@nongnu.org; Thu, 10 Oct 2013 08:17:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUFAd-0003qL-4Z for qemu-devel@nongnu.org; Thu, 10 Oct 2013 08:16:55 -0400 Message-ID: <52569A92.9030400@gmail.com> Date: Thu, 10 Oct 2013 07:16:18 -0500 From: Tom Musta MIME-Version: 1.0 References: <524EBE04.8050207@gmail.com> <524EC167.1010902@gmail.com> <5255B7F8.6030706@twiddle.net> In-Reply-To: <5255B7F8.6030706@twiddle.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/13] Add xxmrgh/xxmrgl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 10/9/2013 3:09 PM, Richard Henderson wrote: > On 10/04/2013 06:23 AM, Tom Musta wrote: >> + tcg_gen_andi_i64(a0, a0, 0xFFFFFFFF00000000ul); \ >> + tcg_gen_shli_i64(a1, a1, 32); \ >> + tcg_gen_shri_i64(b0, b0, 32); \ >> + tcg_gen_andi_i64(b0, b0, 0x00000000FFFFFFFFul); \ >> + tcg_gen_andi_i64(b1, b1, 0x00000000FFFFFFFFul); \ >> + tcg_gen_or_i64(a0, a0, b0); \ >> + tcg_gen_or_i64(a1, a1, b1); \ >> + tcg_gen_mov_i64(cpu_vsrh(xT(ctx->opcode)), a0); \ >> + tcg_gen_mov_i64(cpu_vsrl(xT(ctx->opcode)), a1); \ > Two deposit operations. > > > r~ Richard: Thanks for the comments. I will rework this to use deposit (and also lxvw4x and xxspltw).