From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUFLc-0004BJ-Gv for qemu-devel@nongnu.org; Thu, 10 Oct 2013 08:28:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUFLU-0007Qq-4u for qemu-devel@nongnu.org; Thu, 10 Oct 2013 08:28:08 -0400 Message-ID: <52569D38.3090806@gmail.com> Date: Thu, 10 Oct 2013 07:27:36 -0500 From: Tom Musta MIME-Version: 1.0 References: <524EBE04.8050207@gmail.com> <524EC1A7.7070304@gmail.com> <5255B8D9.4040608@twiddle.net> In-Reply-To: <5255B8D9.4040608@twiddle.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/13] Add xxsel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 10/9/2013 3:13 PM, Richard Henderson wrote: > On 10/04/2013 06:24 AM, Tom Musta wrote: >> + tcg_gen_and_i64(b, b, c); >> + tcg_gen_not_i64(c, c); >> + tcg_gen_and_i64(a, a, c); > tcg_gen_andc_i64. > >> +#define GEN_XXSEL() \ >> +GEN_XXSEL_ROW(0x00) \ >> +GEN_XXSEL_ROW(0x01) \ > Why bother with defining GEN_XXSEL when its only used once? > Surely just put the rows there. > > OTOH, this does suggest that we could do with a better way > to decode the instructions, because this is ugly... > > > r~ Yeah ... it isn't very pretty. There was precedent for this (see, for example, rldcl). And the decoding logic very much wants to use instruction bits 26:30 and 21:25 as opc2 and opc3 respectively. Perhaps I could inject a handler for opcode 60 that would handle the VSX map a little more gracefully. Is your concern aesthetic? Memory consumption? And do you feel this is a showstopper or something that could be addressed later?