All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Renner <renner-Xf229rFC5gsb1SvskN2V4Q@public.gmane.org>
To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: broonie-GFdadSzt00ze9xe1eoZjHA@public.gmane.org,
	Michal Simek
	<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH][RESEND] spi/xilinx: Use DT information for bits_per_word value, fix bus_num value
Date: Thu, 10 Oct 2013 15:45:40 +0200	[thread overview]
Message-ID: <5256AF84.90500@efe-gmbh.de> (raw)
In-Reply-To: <5256A186.5030708-Xf229rFC5gsb1SvskN2V4Q@public.gmane.org>

This patch overrides the default value of bits_per_word with the actual value
of "xlnx,num-transfer-bits" from the DTS file to allow for 16 and 32 bit word
lengths.
Also, bus_num always was (and probably should still be) derived from pdev->id.
Otherwise this could lead to problems when using more than one SPI master.

Tested on our own Spartan-6 / Microblaze platform with two SPI controllers.

Signed-off-by: Jens Renner <renner-Xf229rFC5gsb1SvskN2V4Q@public.gmane.org>
---
 drivers/spi/spi-xilinx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
index 0bf1b2c..5a6d9c5 100644
--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -356,6 +356,8 @@ static int xilinx_spi_probe(struct platform_device *pdev)
 	} else {
 		of_property_read_u32(pdev->dev.of_node, "xlnx,num-ss-bits",
 					  &num_cs);
+		of_property_read_u32(pdev->dev.of_node, "xlnx,num-transfer-bits",
+					&bits_per_word);
 	}
 
 	if (!num_cs) {
@@ -385,7 +387,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
 		goto put_master;
 	}
 
-	master->bus_num = pdev->dev.id;
+	master->bus_num = pdev->id;
 	master->num_chipselect = num_cs;
 	master->dev.of_node = pdev->dev.of_node;
 


------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk

  parent reply	other threads:[~2013-10-10 13:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-10 12:45 [PATCH] spi/xilinx: Use DT information for bits_per_word value, fix bus_num value Jens Renner
     [not found] ` <5256A186.5030708-Xf229rFC5gsb1SvskN2V4Q@public.gmane.org>
2013-10-10 13:45   ` Jens Renner [this message]
     [not found] ` <20131010141221.GN21581@sirena.org.uk>
     [not found]   ` <20131010141221.GN21581-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-10-10 14:50     ` Jens Renner
     [not found]       ` <5256BEBD.1090907-Xf229rFC5gsb1SvskN2V4Q@public.gmane.org>
2013-10-10 21:44         ` Trent Piepho
     [not found]           ` <20131010225147.GX21581@sirena.org.uk>
     [not found]             ` <20131010225147.GX21581-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-10-10 23:15               ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5256AF84.90500@efe-gmbh.de \
    --to=renner-xf229rfc5gsb1svskn2v4q@public.gmane.org \
    --cc=broonie-GFdadSzt00ze9xe1eoZjHA@public.gmane.org \
    --cc=michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.