From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH 6/7] xen/arm: Basic support for sunxi/sun7i platform.
Date: Thu, 10 Oct 2013 15:23:47 +0100 [thread overview]
Message-ID: <5256B873.7010200@linaro.org> (raw)
In-Reply-To: <1381225844.3804.62.camel@hastur.hellion.org.uk>
On 10/08/2013 10:50 AM, Ian Campbell wrote:
> On Fri, 2013-09-20 at 19:55 +0100, Julien Grall wrote:
>
>>> +
>>> +static const char const *sunxi_dt_compat[] __initdata =
>>
>> It should be __initconst.
>
> Together with the 7/7 patch (uart blacklisting) doing this causes:
> sunxi.c:21:26: error: sunxi_dt_compat causes a section type conflict with sunxi_blacklist_dev
> static const char const *sunxi_dt_compat[] __initconst =
> ^
> sunxi.c:27:37: note: ‘sunxi_blacklist_dev’ was declared here
> static const struct dt_device_match sunxi_blacklist_dev[] __initconst =
> ^
> I'm not sure why this would be, but I notice that vexpress and exynos5
> both use __initdata for their dt_compat lists and __initconst for their
> blacklists.
>
> Any thoughts?
It's because the const should be after * in sunxi_dt_compat ie
static const char * const sunxi_dt_compat[] __initconst =
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-10-10 14:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 16:17 [PATCH v3 0/7] support for cubieboard2 / sunxi processors Ian Campbell
2013-09-20 16:18 ` [PATCH 1/7] xen/arm: Implement ioremap Ian Campbell
2013-09-20 16:18 ` [PATCH 3/7] ns16550: make usable on ARM Ian Campbell
2013-09-20 16:18 ` [PATCH 4/7] ns16550: support DesignWare 8250 Ian Campbell
2013-09-20 16:18 ` [PATCH 5/7] xen/arm: Support Cortex-A7 GIC Ian Campbell
2013-09-20 18:51 ` Julien Grall
2013-09-20 16:18 ` [PATCH 6/7] xen/arm: Basic support for sunxi/sun7i platform Ian Campbell
2013-09-20 18:55 ` Julien Grall
2013-09-20 19:01 ` Ian Campbell
2013-10-08 9:50 ` Ian Campbell
2013-10-10 14:23 ` Julien Grall [this message]
2013-10-11 8:31 ` Ian Campbell
2013-09-20 16:18 ` [PATCH 7/7] xen/arm: Blacklist some sun7i UARTs Ian Campbell
2013-09-20 19:02 ` Julien Grall
2013-09-20 21:41 ` Ian Campbell
2013-09-21 20:28 ` Julien Grall
2013-09-22 14:40 ` Ian Campbell
2013-09-27 17:02 ` Julien Grall
2013-09-27 17:04 ` Andrew Cooper
2013-09-30 9:19 ` Ian Campbell
2013-09-21 15:59 ` [PATCH v3 0/7] support for cubieboard2 / sunxi processors Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5256B873.7010200@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.