From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] buildman: don't fail --list-toolchains when toolchains fail
Date: Thu, 10 Oct 2013 09:48:33 -0600 [thread overview]
Message-ID: <5256CC51.8060500@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ06AqpOf8BNo-cHKbhiOT83T0QQPeK2SVSBvGsN2Y6iHQ@mail.gmail.com>
On 10/09/2013 04:24 PM, Simon Glass wrote:
> On Wed, Oct 9, 2013 at 2:28 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> When a toolchain invocation fails, an exception is thrown but not caught
>> which then aborts the entire toolchain detection process. To solve this,
>> request that exceptions not be thrown, since the toolchain init code
>> already error-checks the command result. This solves e.g.:
>>
>> - found '/usr/bin/winegcc'
>> Traceback (most recent call last):
>> ...
>> Exception: Error running '/usr/bin/winegcc --version'
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> Acked-by: Simon Glass <sjg@chromium.org>
Thanks. Oh. I didn't send this patch directly to any person other than
you, since I thought you collected patches and sent pull requests for
it. Should I resend it to Tom Rini?
next prev parent reply other threads:[~2013-10-10 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 20:28 [U-Boot] [PATCH 1/2] buildman: don't fail --list-toolchains when toolchains fail Stephen Warren
2013-10-09 20:28 ` [U-Boot] [PATCH 2/2] buildman: make board selector argument a regex Stephen Warren
2013-10-09 22:28 ` Simon Glass
2013-10-09 22:24 ` [U-Boot] [PATCH 1/2] buildman: don't fail --list-toolchains when toolchains fail Simon Glass
2013-10-10 15:48 ` Stephen Warren [this message]
2013-10-10 15:50 ` Simon Glass
2013-10-10 16:04 ` Stephen Warren
2013-10-10 16:42 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5256CC51.8060500@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.