From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 10 Oct 2013 10:04:21 -0600 Subject: [U-Boot] [PATCH 1/2] buildman: don't fail --list-toolchains when toolchains fail In-Reply-To: References: <1381350490-25867-1-git-send-email-swarren@wwwdotorg.org> <5256CC51.8060500@wwwdotorg.org> Message-ID: <5256D005.9000807@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/10/2013 09:50 AM, Simon Glass wrote: > Hi Stephen, > > On Thu, Oct 10, 2013 at 9:48 AM, Stephen Warren wrote: >> On 10/09/2013 04:24 PM, Simon Glass wrote: >>> On Wed, Oct 9, 2013 at 2:28 PM, Stephen Warren wrote: >>>> From: Stephen Warren >>>> >>>> When a toolchain invocation fails, an exception is thrown but not caught >>>> which then aborts the entire toolchain detection process. To solve this, >>>> request that exceptions not be thrown, since the toolchain init code >>>> already error-checks the command result. This solves e.g.: >>>> >>>> - found '/usr/bin/winegcc' >>>> Traceback (most recent call last): >>>> ... >>>> Exception: Error running '/usr/bin/winegcc --version' >>>> >>>> Signed-off-by: Stephen Warren >>> >>> Acked-by: Simon Glass >> >> Thanks. Oh. I didn't send this patch directly to any person other than >> you, since I thought you collected patches and sent pull requests for >> it. Should I resend it to Tom Rini? > > Yes I tend to do that. Perhaps this should go into the release? Let me > know - I'll do a little pull request for Tom. At least patch 1 sounds like a good idea for the release since it's a bug-fix, yes.