From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c
Date: Thu, 10 Oct 2013 10:07:38 -0600 [thread overview]
Message-ID: <5256D0CA.9010906@wwwdotorg.org> (raw)
In-Reply-To: <20131010111328.GS4233@tbergstrom-lnx.Nvidia.com>
On 10/10/2013 05:13 AM, Peter De Schrijver wrote:
> On Tue, Oct 08, 2013 at 06:09:24PM +0200, Stephen Warren wrote:
>> On 10/08/2013 05:17 AM, Sachin Kamat wrote:
>>> Local variables used only in this file are made static.
>>
>
> Conceptually they are still exported. So I think it's counterintuitive to
> declare them static. Unless you expect namespace problems, I would rather
> leave it as is.
I forget exactly which symbols this patch changed, but presumably
they're only exported via pointers rather than by symbol name, and isn't
that exactly what static is for?
next prev parent reply other threads:[~2013-10-10 16:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 11:17 [PATCH Resend 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
2013-10-08 11:17 ` [PATCH 02/10] clk: SPEAr: Staticize clk_frac_ops Sachin Kamat
2013-10-08 11:17 ` [PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c Sachin Kamat
2013-10-08 16:09 ` Stephen Warren
2013-10-10 11:13 ` Peter De Schrijver
2013-10-10 16:07 ` Stephen Warren [this message]
2013-10-14 8:15 ` Peter De Schrijver
2013-10-14 16:35 ` Stephen Warren
2013-10-15 8:29 ` Peter De Schrijver
2013-10-15 15:10 ` Stephen Warren
2013-12-20 1:53 ` Mike Turquette
2013-10-08 11:17 ` [PATCH 04/10] clk: tegra: Staticize tegra_clk_periph_nodiv_ops Sachin Kamat
2013-10-08 11:17 ` [PATCH 05/10] clk: socfpga: Use NULL instead of 0 Sachin Kamat
2013-10-08 11:17 ` [PATCH 06/10] clk: versatile: Staticize clk_sp810_timerclken_of_get Sachin Kamat
2013-10-08 11:17 ` [PATCH 07/10] clk: mvebu: Staticize of_cpu_clk_setup Sachin Kamat
2013-10-08 11:17 ` [PATCH 08/10] clk: vt8500: Staticize vtwm_pll_ops Sachin Kamat
2013-10-08 11:17 ` [PATCH 09/10] clk: ux500: Remove extra semicolon Sachin Kamat
2013-10-08 11:17 ` [PATCH 10/10] clk: max77686: Remove redundant break Sachin Kamat
2013-12-05 11:27 ` [PATCH Resend 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h Sachin Kamat
2013-12-20 1:59 ` Mike Turquette
2013-12-20 3:58 ` Sachin Kamat
2013-12-23 7:59 ` Mike Turquette
-- strict thread matches above, loose matches on Subject: below --
2013-09-13 9:23 [PATCH " Sachin Kamat
2013-09-13 9:23 ` [PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5256D0CA.9010906@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.