From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Fantoni Subject: Re: [PATCH v2] libxl: remove qemu default devices for upstream qemu Date: Fri, 11 Oct 2013 09:53:08 +0200 Message-ID: <5257AE64.30507@m2r.biz> References: <1380541988-6105-1-git-send-email-fabio.fantoni@m2r.biz> <52541C05.9020606@m2r.biz> <52541C98.5070509@eu.citrix.com> <20131010164900.GA3195@perard.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131010164900.GA3195@perard.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Anthony PERARD Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, Stefano.Stabellini@eu.citrix.com, George Dunlap , Ian.Jackson@eu.citrix.com, wei.lui2@citrix.com List-Id: xen-devel@lists.xenproject.org Il 10/10/2013 18:49, Anthony PERARD ha scritto: > On Tue, Oct 08, 2013 at 03:54:16PM +0100, George Dunlap wrote: >> On 10/08/2013 03:51 PM, Fabio Fantoni wrote: >>> Il 30/09/2013 13:53, Fabio Fantoni ha scritto: >>>> Remove default devices created by qemu. Qemu will create only devices >>>> defined by xen, since the devices not defined by xen are not usable. >>>> Remove deleting of empty floppy no more needed with nodefault. >>> Any comment on this? >>> >>> Thanks for any reply. >> It sounds like a good idea to me, but I'm not in a position to >> review it. You should CC Anthony Perard along with Stefano for >> patches that have to do with qemu. > After applying the patch, there is three things that goes away: > - the parallel port > - an empty cdrom driver, if xl does not ask for one > - a block device reported by qemu as "sd0" > > So, parallel, I suppose that can go away, as it's not usubal (by default > the output go to the graphic output). The "sd0" seems to be an sdcard > slot, but I don't think we can use it from xl. And the last one, the > cdrom driver is also not usubal from xl, if one want to insert a cd into > it, the cdrom driver need to be in the vm config file. > > So, I'm happy with the patch: > > Acked-by: Anthony PERARD > Thanks for your reply, can you check also this post please? http://lists.xen.org/archives/html/xen-devel/2013-10/msg00843.html