Re: [Qemu-devel] [PATCH v2 2/2] vmdk: implment bdrv_get_specific_info

[Max Reitz <mreitz@redhat.com>]

On 2013-10-11 14:07, Fam Zheng wrote:
> On Fri, 10/11 05:52, Eric Blake wrote:
>> On 10/11/2013 02:31 AM, Fam Zheng wrote:
>>> Implement .bdrv_get_specific_info to return the extent information.
>>>
>>> Signed-off-by: Fam Zheng <famz@redhat.com>
>>> ---
>>> +
>>> +    *spec_info->vmdk = (ImageInfoSpecificVmdk) {
>>> +        .create_type = g_strdup(s->create_type),
>>> +        .cid = s->cid,
>>> +    };
>>> +
>>>   
>>>   ##
>>> +# @ImageInfoSpecificVmdk:
>>> +#
>>> +# @create_type: The create type of VMDK image
>> Is it worth making this an enum type rather than an open-coded string?
>> But that's not a show-stopper to me.
> For now I think a string is good enough, it's only used to display with
> qemu-img info, string type saves converting in opening code, as well as
> repeating type names in multiple places.

Actually, it can be queried through QMP (query-block) as well. But I 
personally don't oppose using a string here.

Max