From: Cole Robinson <crobinso@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: alex.williamson@redhat.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub message
Date: Fri, 11 Oct 2013 11:49:20 -0400 [thread overview]
Message-ID: <52581E00.8080403@redhat.com> (raw)
In-Reply-To: <87y560tjmj.fsf@blackfin.pond.sub.org>
On 10/11/2013 02:19 AM, Markus Armbruster wrote:
> Cole Robinson <crobinso@redhat.com> writes:
>
>> Using multiple calls to error_report here means every line is
>> prefaced with the (potentially long) pci-assign command line
>> arguments. Use a single error_report to preserve the intended
>> formatting.
>
> The orthodox way to do this is to use error_report() for the
> (single-line!) error message, then error_printf() for additional
> information. See commit 2da2e52..312fd5f for an example.
>
Sounds good. This code path is always preceded by an error_report() call, we
can just change this massive message to error_printf().
- Cole
prev parent reply other threads:[~2013-10-11 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 16:58 [Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub message Cole Robinson
2013-10-10 17:03 ` Alex Williamson
2013-10-11 6:19 ` Markus Armbruster
2013-10-11 15:49 ` Cole Robinson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52581E00.8080403@redhat.com \
--to=crobinso@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.