From: Mike Dunn <mikedunn@newsguy.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org, Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] [RESEND] mtd: docg4: fix status polling loop
Date: Fri, 11 Oct 2013 11:31:18 -0700 [thread overview]
Message-ID: <525843F6.8050907@newsguy.com> (raw)
In-Reply-To: <20131011181615.GK23337@ld-irv-0074.broadcom.com>
On 10/11/2013 11:16 AM, Brian Norris wrote:
> Hi Mike,
>
> On Thu, Oct 10, 2013 at 10:25:27AM -0700, Mike Dunn wrote:
>> The loop that polls the status register waiting for an operation to complete
>> foolishly bases the timeout simply on the number of loop iterations that have
>> ocurred. When I increased the processor clock speed, timeouts started to appear
>> for long block erasure operations. This patch measures the timeout using
>> jiffies.
>>
>> Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
>> ---
>>
>> This is a rework of an earlier patch, based on Artem's recommendation to use
>> jiffies, not udelay() (thanks Artem). I didn't mark it 'v2' because the rework
>> makes the original name of the patch inaccurate, so now it has a different name.
>>
>> This was originally sent a couple months ago... was probably a bad time.
>
> Wow, this identical patch was sent as far back as May 31 and is being
> submitted for the 3rd time now :( I hope there will be fewer "bad times"
> like this in the future.
Thanks much Brian. No big deal. There's only one other user of this driver
that I'm aware of :(
Thanks also for volunteering to shoulder some of the mtd maintenance duties.
Good job!
Mike
next prev parent reply other threads:[~2013-10-11 18:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 17:25 [PATCH] [RESEND] mtd: docg4: fix status polling loop Mike Dunn
2013-10-11 18:16 ` Brian Norris
2013-10-11 18:31 ` Mike Dunn [this message]
2013-10-11 20:38 ` Brian Norris
-- strict thread matches above, loose matches on Subject: below --
2013-08-05 17:55 Mike Dunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525843F6.8050907@newsguy.com \
--to=mikedunn@newsguy.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.