From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VUiOS-0006jj-Qm for mharc-qemu-trivial@gnu.org; Fri, 11 Oct 2013 15:29:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUiOL-0006Y9-2G for qemu-trivial@nongnu.org; Fri, 11 Oct 2013 15:28:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUiOF-0004Fo-Is for qemu-trivial@nongnu.org; Fri, 11 Oct 2013 15:28:53 -0400 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:39795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUiO4-0004CV-Qv; Fri, 11 Oct 2013 15:28:36 -0400 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id 1BDEC72819F6; Fri, 11 Oct 2013 21:28:35 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AFEBbP2fGVL6; Fri, 11 Oct 2013 21:28:24 +0200 (CEST) Received: from [192.168.178.35] (p54AD83DE.dip0.t-ipconnect.de [84.173.131.222]) by v220110690675601.yourvserver.net (Postfix) with ESMTPSA id 9C99272809F3; Fri, 11 Oct 2013 21:28:23 +0200 (CEST) Message-ID: <52585156.1010707@weilnetz.de> Date: Fri, 11 Oct 2013 21:28:22 +0200 From: Stefan Weil User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Peter Maydell References: <1381518382-6105-1-git-send-email-sw@weilnetz.de> In-Reply-To: X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 37.221.199.173 Cc: qemu-trivial , Jan Kiszka , Alex Bligh , qemu-devel , Anthony Liguori Subject: Re: [Qemu-trivial] [PATCH v2] misc: Spelling and other fixes in comments X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Oct 2013 19:28:59 -0000 Am 11.10.2013 21:12, schrieb Peter Maydell: > On 12 October 2013 04:06, Stefan Weil wrote: >> * it's -> its >> * Grammar fix in ui/vnc-enc-zywrle.h. In the same context >> a sentence with unclear meaning which could not be fixed was removed. >> >> Signed-off-by: Stefan Weil >> --- >> >> This is an update of patch http://patchwork.ozlabs.org/patch/257416/ >> (Spelling fixes). >> >> v2: Don't try to fix a strange sentence in ui/vnc-enc-zywrle.h - remove it. > What? I thought you meant "remove that part of the change from > the patch", not "remove the sentence altogether". Please leave > it in place so that anybody in future who needs to try to understand > this code has the maximum available amount of clues. > > -- PMM Well, I said "Would you agree on fixing the first line only and removing the two following lines?". Obviously it's not so easy for foreign speakers like me to find the right words. :-) I'll send a v3. Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUiOA-0006Pl-9E for qemu-devel@nongnu.org; Fri, 11 Oct 2013 15:28:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUiO5-0004Cf-0L for qemu-devel@nongnu.org; Fri, 11 Oct 2013 15:28:42 -0400 Message-ID: <52585156.1010707@weilnetz.de> Date: Fri, 11 Oct 2013 21:28:22 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1381518382-6105-1-git-send-email-sw@weilnetz.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] misc: Spelling and other fixes in comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial , Jan Kiszka , Alex Bligh , qemu-devel , Anthony Liguori Am 11.10.2013 21:12, schrieb Peter Maydell: > On 12 October 2013 04:06, Stefan Weil wrote: >> * it's -> its >> * Grammar fix in ui/vnc-enc-zywrle.h. In the same context >> a sentence with unclear meaning which could not be fixed was removed. >> >> Signed-off-by: Stefan Weil >> --- >> >> This is an update of patch http://patchwork.ozlabs.org/patch/257416/ >> (Spelling fixes). >> >> v2: Don't try to fix a strange sentence in ui/vnc-enc-zywrle.h - remove it. > What? I thought you meant "remove that part of the change from > the patch", not "remove the sentence altogether". Please leave > it in place so that anybody in future who needs to try to understand > this code has the maximum available amount of clues. > > -- PMM Well, I said "Would you agree on fixing the first line only and removing the two following lines?". Obviously it's not so easy for foreign speakers like me to find the right words. :-) I'll send a v3. Stefan