From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] uboot: support -r option for mkenvimage
Date: Fri, 11 Oct 2013 23:18:48 +0200 [thread overview]
Message-ID: <52586B38.6010306@mind.be> (raw)
In-Reply-To: <1381478269-29943-1-git-send-email-spdawson@gmail.com>
On 11/10/13 09:57, spdawson at gmail.com wrote:
> From: Simon Dawson <spdawson@gmail.com>
>
> Some boards are configured in u-boot to store multiple redundant copies of
> the environment image in flash. For these boards, it is required to pass the -r
> flag, when generating a boot environment image using mkenvimage.
>
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
> boot/uboot/Config.in | 5 +++++
> boot/uboot/uboot.mk | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> index 998cda2..d33e8e1 100644
> --- a/boot/uboot/Config.in
> +++ b/boot/uboot/Config.in
> @@ -242,6 +242,11 @@ config BR2_TARGET_UBOOT_ENVIMAGE_SIZE
> Size of envronment, can be prefixed with 0x for hexadecimal
> values.
>
> +config BR2_TARGET_UBOOT_ENVIMAGE_REDUNDANT
> + bool "Redundant environment"
"Redundant environment" sounds as if it's... redundant :-)
How about "Environment has two copies"?
> + help
> + The environment has multiple copies in flash.
It's always two :-)
Regards,
Arnout
> +
> endif # BR2_TARGET_UBOOT_ENVIMAGE
>
> endif # BR2_TARGET_UBOOT
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index dc8e26f..330c177 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -117,6 +117,7 @@ define UBOOT_INSTALL_IMAGES_CMDS
> cp -dpf $(@D)/$(BR2_TARGET_UBOOT_SPL_NAME) $(BINARIES_DIR)/)
> $(if $(BR2_TARGET_UBOOT_ENVIMAGE),
> $(HOST_DIR)/usr/bin/mkenvimage -s $(BR2_TARGET_UBOOT_ENVIMAGE_SIZE) \
> + $(if $(BR2_TARGET_UBOOT_ENVIMAGE_REDUNDANT),-r) \
> -o $(BINARIES_DIR)/uboot-env.bin $(BR2_TARGET_UBOOT_ENVIMAGE_SOURCE))
> endef
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-10-11 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 7:57 [Buildroot] [PATCH] uboot: support -r option for mkenvimage spdawson at gmail.com
2013-10-11 21:18 ` Arnout Vandecappelle [this message]
2013-10-11 21:21 ` Thomas Petazzoni
2013-10-12 10:00 ` Simon Dawson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52586B38.6010306@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.