From: Jonathan Cameron <jic23@kernel.org>
To: Joe Perches <joe@perches.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-iio <linux-iio@vger.kernel.org>,
devel <devel@driverdev.osuosl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Trivial PATCH] staging: Remove unnecessary semicolons
Date: Sat, 12 Oct 2013 11:44:50 +0100 [thread overview]
Message-ID: <52592822.2030304@kernel.org> (raw)
In-Reply-To: <1381446479.14017.16.camel@joe-AO722>
On 10/11/13 00:07, Joe Perches wrote:
> These aren't necessary after switch, if and while statements.
>
> Also remove some unnecessary braces where these
> semicolons were removed around single statement
> and some unnecessary blank lines.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
(for the iio ones).
> ---
> drivers/staging/iio/adc/ad7291.c | 2 +-
> drivers/staging/iio/cdc/ad7150.c | 2 +-
> drivers/staging/imx-drm/imx-tve.c | 2 +-
> drivers/staging/lustre/lustre/lvfs/lvfs_linux.c | 2 +-
> drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
> drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 10 ++--------
> 6 files changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7291.c b/drivers/staging/iio/adc/ad7291.c
> index 1dae1ef..ccaa8d6f8 100644
> --- a/drivers/staging/iio/adc/ad7291.c
> +++ b/drivers/staging/iio/adc/ad7291.c
> @@ -290,7 +290,7 @@ static int ad7291_read_event_value(struct iio_dev *indio_dev,
> return 0;
> default:
> return -EINVAL;
> - };
> + }
> }
>
> static int ad7291_write_event_value(struct iio_dev *indio_dev,
> diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
> index f4a0341..618d820 100644
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -300,7 +300,7 @@ static int ad7150_read_event_value(struct iio_dev *indio_dev,
>
> default:
> return -EINVAL;
> - };
> + }
> }
>
> static int ad7150_write_event_value(struct iio_dev *indio_dev,
> diff --git a/drivers/staging/imx-drm/imx-tve.c b/drivers/staging/imx-drm/imx-tve.c
> index 33d6525..59dd4d5 100644
> --- a/drivers/staging/imx-drm/imx-tve.c
> +++ b/drivers/staging/imx-drm/imx-tve.c
> @@ -696,7 +696,7 @@ static int imx_tve_probe(struct platform_device *pdev)
> if (val != 0x00100000) {
> dev_err(&pdev->dev, "configuration register default value indicates this is not a TVEv2\n");
> return -ENODEV;
> - };
> + }
>
> /* disable cable detection for VGA mode */
> ret = regmap_write(tve->regmap, TVE_CD_CONT_REG, 0);
> diff --git a/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c b/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c
> index f6268dc..ea37715 100644
> --- a/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c
> +++ b/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c
> @@ -282,7 +282,7 @@ __s64 lprocfs_read_helper(struct lprocfs_counter *lc,
> break;
> default:
> break;
> - };
> + }
>
> return ret;
> }
> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_recv.c
> index ba8e534..9f0f30f7 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> @@ -1586,7 +1586,7 @@ _func_enter_;
>
> pfhdr->attrib.icv_len = pnfhdr->attrib.icv_len;
> plist = get_next(plist);
> - };
> + }
>
> /* free the defrag_q queue and return the prframe */
> rtw_free_recvframe_queue(defrag_q, pfree_recv_queue);
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
> index 7d322f3..b01f6f5 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
> @@ -1888,9 +1888,8 @@ void rtl8192_hard_data_xmit(struct sk_buff *skb, struct net_device *dev,
> memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
> skb_push(skb, priv->rtllib->tx_headroom);
> ret = rtl8192_tx(dev, skb);
> - if (ret != 0) {
> + if (ret != 0)
> kfree_skb(skb);
> - };
>
> if (queue_index != MGNT_QUEUE) {
> priv->rtllib->stats.tx_bytes += (skb->len -
> @@ -1898,7 +1897,6 @@ void rtl8192_hard_data_xmit(struct sk_buff *skb, struct net_device *dev,
> priv->rtllib->stats.tx_packets++;
> }
>
> -
> return;
> }
>
> @@ -1930,15 +1928,11 @@ int rtl8192_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
> tcb_desc->bTxEnableFwCalcDur = 1;
> skb_push(skb, priv->rtllib->tx_headroom);
> ret = rtl8192_tx(dev, skb);
> - if (ret != 0) {
> + if (ret != 0)
> kfree_skb(skb);
> - };
> }
>
> -
> -
> return ret;
> -
> }
>
> static void rtl8192_tx_isr(struct net_device *dev, int prio)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-10-12 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 23:07 [Trivial PATCH] staging: Remove unnecessary semicolons Joe Perches
2013-10-12 10:44 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52592822.2030304@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.