From: Jonathan Cameron <jic23@kernel.org>
To: Marek Vasut <marex@denx.de>, Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org, Stefan Roese <sr@denx.de>,
Roland Stigge <stigge@antcom.de>
Subject: Re: [PATCH 2/2] staging:iio: Allow to build SoC specific drivers when COMPILE_TEST is set
Date: Sat, 12 Oct 2013 13:33:36 +0100 [thread overview]
Message-ID: <525941A0.7090706@kernel.org> (raw)
In-Reply-To: <201310071635.49502.marex@denx.de>
On 10/07/13 15:35, Marek Vasut wrote:
> Dear Lars-Peter Clausen,
>
>> On 10/07/2013 03:26 PM, Lars-Peter Clausen wrote:
>>> None of the SPEAr, LPC32XX or MXS ADC drivers have a compile time
>>> dependency on their respective platform. So make it possible to build
>>> the drivers when CONFIG_COMPILE_TEST is set. This makes it easier to
>>> compile test changes.
>>>
I'm getting a ERROR: "stmp_reset_block" [drivers/staging/iio/adc/mxs-lradc.ko] undefined!
Also for reference also the following warnings from a build with sparse enabled.
CHECK drivers/staging/iio/adc/mxs-lradc.c
drivers/staging/iio/adc/mxs-lradc.c:1298:25: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/iio/adc/mxs-lradc.c:1298:25: expected void const *ptr
drivers/staging/iio/adc/mxs-lradc.c:1298:25: got void [noderef] <asn:2>*base
drivers/staging/iio/adc/mxs-lradc.c:1299:37: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/iio/adc/mxs-lradc.c:1299:37: expected void const *ptr
drivers/staging/iio/adc/mxs-lradc.c:1299:37: got void [noderef] <asn:2>*base
CC [M] drivers/staging/iio/adc/mxs-lradc.o
CHECK drivers/staging/iio/adc/spear_adc.c
drivers/staging/iio/adc/spear_adc.c:321:18: warning: cast removes address space of expression
drivers/staging/iio/adc/spear_adc.c:320:33: warning: incorrect type in assignment (different address spaces)
drivers/staging/iio/adc/spear_adc.c:320:33: expected struct adc_regs_spear3xx [noderef] <asn:2>*adc_base_spear3xx
drivers/staging/iio/adc/spear_adc.c:320:33: got struct adc_regs_spear3xx *<noident>
I haven't even glanced at what caused these as yet.
>>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>>> Cc: Stefan Roese <sr@denx.de>
>>> Cc: Marek Vasut <marex@denx.de
>>
>> Missing > here, added Marek to Cc manually
>
> Thanks. Makes sense to me
>
> Reviewed-by: Marek Vasut <marex@denx.de>
>
> Best regards,
> Marek Vasut
>
next prev parent reply other threads:[~2013-10-12 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 13:26 [PATCH 1/2] staging:iio:spear_adc: Remove unused variable Lars-Peter Clausen
2013-10-07 13:26 ` [PATCH 2/2] staging:iio: Allow to build SoC specific drivers when COMPILE_TEST is set Lars-Peter Clausen
2013-10-07 13:27 ` Lars-Peter Clausen
2013-10-07 14:35 ` Marek Vasut
2013-10-12 12:33 ` Jonathan Cameron [this message]
2013-10-12 11:53 ` Lars-Peter Clausen
2013-10-12 12:33 ` [PATCH 1/2] staging:iio:spear_adc: Remove unused variable Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525941A0.7090706@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
--cc=sr@denx.de \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.