Re: [Qemu-devel] [PATCH V3 7/7] qemu-iotests: add test for qcow2 snapshot

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

于 2013/10/1 6:28, Eric Blake 写道:
> On 09/08/2013 08:58 PM, Wenchao Xia wrote:
>> This test will focus on the low level procedure of qcow2 snapshot
>> operations, now it covers only the create operation. Overlap error
>> paths are not checked since no good way to trigger those errors.
>>
>> Signed-off-by: Wenchao Xia<xiawenc@linux.vnet.ibm.com>
>> ---
>>   tests/qemu-iotests/063     |  229 ++++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/063.out |   37 +++++++
>>   tests/qemu-iotests/group   |    1 +
>>   3 files changed, 267 insertions(+), 0 deletions(-)
>>   create mode 100755 tests/qemu-iotests/063
>>   create mode 100644 tests/qemu-iotests/063.out
>>
>> +# only test qcow2
>> +_supported_fmt qcow2
>> +_supported_proto generic
>> +_supported_os Linux
>> +
>> +IMGOPTS="compat=1.1"
>> +
>> +CLUSTER_SIZE=65536
>> +
>> +SIZE=1G
>> +
>> +BLKDBG_TEST_IMG="blkdebug:$TEST_DIR/blkdebug.conf:$TEST_IMG"
>> +
>> +errno=5
> Not all platforms have errno 5 tied to EIO; but then again, you filtered
> this test to run only on Linux.  Is it possible to be a bit more
> generic, though?
>
   I think the test can be made more generic, but it is a bit hard for 
me to find out
what number should be used on all platform now. Instead, I'd like to add 
a comments
here:"bind the errno correctly if you want run this case on other platform".

> At any rate, more tests are always good.  I didn't read very closely;
> but I also didn't see anything obviously wrong with the patch, and it is
> self-validating whether the testsuite still passes after applying it.
> So feel free to add:
>
> Reviewed-by: Eric Blake<eblake@redhat.com>
>