From: Jiri Slaby <jslaby@suse.cz>
To: Michael Opdenacker <michael.opdenacker@free-electrons.com>,
arnd@arndb.de, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: phantom: remove deprecated IRQF_DISABLED
Date: Mon, 14 Oct 2013 10:49:41 +0200 [thread overview]
Message-ID: <525BB025.8080508@suse.cz> (raw)
In-Reply-To: <1381644967-9419-1-git-send-email-michael.opdenacker@free-electrons.com>
On 10/13/2013 08:16 AM, Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Acked-by: Jiri Slaby <jslaby@suse.cz>
Thanks.
> ---
> drivers/misc/phantom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/phantom.c b/drivers/misc/phantom.c
> index 68b7c77..3075492 100644
> --- a/drivers/misc/phantom.c
> +++ b/drivers/misc/phantom.c
> @@ -395,7 +395,7 @@ static int phantom_probe(struct pci_dev *pdev,
> iowrite32(0, pht->caddr + PHN_IRQCTL);
> ioread32(pht->caddr + PHN_IRQCTL); /* PCI posting */
> retval = request_irq(pdev->irq, phantom_isr,
> - IRQF_SHARED | IRQF_DISABLED, "phantom", pht);
> + IRQF_SHARED, "phantom", pht);
> if (retval) {
> dev_err(&pdev->dev, "can't establish ISR\n");
> goto err_unmo;
>
--
js
suse labs
prev parent reply other threads:[~2013-10-14 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 6:16 [PATCH] misc: phantom: remove deprecated IRQF_DISABLED Michael Opdenacker
2013-10-14 8:49 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525BB025.8080508@suse.cz \
--to=jslaby@suse.cz \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.opdenacker@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.