From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH] Add scripts/get_maintainer.pl Date: Mon, 14 Oct 2013 11:53:50 -0400 Message-ID: <525C138E.4040504@terremark.com> References: <1380752562-24760-1-git-send-email-dslutz@verizon.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Matthew Daley , Don Slutz Cc: Keir Fraser , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Here is a diff that does both: From 87da940264756820e86d931aefc1b64998a18b92 Mon Sep 17 00:00:00 2001 From: Don Slutz Date: Tue, 8 Oct 2013 20:13:58 -0400 Subject: [PATCH 1/2] get_maintainer.pl: Adjust defaults Signed-off-by: Don Slutz --- scripts/get_maintainer.pl | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 821912c..44e2532 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -28,7 +28,7 @@ my $email_git = 0; my $email_git_all_signature_types = 0; my $email_git_blame = 0; my $email_git_blame_signatures = 1; -my $email_git_fallback = 1; +my $email_git_fallback = 0; my $email_git_min_signatures = 1; my $email_git_max_maintainers = 5; my $email_git_min_percent = 5; @@ -40,7 +40,7 @@ my $email_use_mailmap = 1; my $output_multiline = 1; my $output_separator = ", "; my $output_roles = 0; -my $output_rolestats = 1; +my $output_rolestats = 0; my $scm = 0; my $web = 0; my $subsystem = 0; @@ -794,7 +794,7 @@ Notes: --git-min-signatures, --git-max-maintainers, --git-min-percent, and --git-blame Use --hg-since not --git-since to control date selection - File ".get_maintainer.conf", if it exists in the QEMU source root + File ".get_maintainer.conf", if it exists in the XEN source root directory, can change whatever get_maintainer defaults are desired. Entries in this file can be any command line argument. This file is prepended to any additional command line arguments. -- 1.7.1 I will squash this into 1 change for v2. -Don Slutz On 10/04/13 03:25, Matthew Daley wrote: > On Fri, Oct 4, 2013 at 7:03 PM, Matthew Daley wrote: >> On Thu, Oct 3, 2013 at 11:22 AM, Don Slutz wrote: >>> This is a minor change to QEMU's scripts/get_maintainer.pl to work in a XEN souce tree. >>> >>> Signed-off-by: Don Slutz >> I've used a similarly-modified get_maintainers script (also from QEMU) >> lately and have found it useful (ie. with treewide Coverity fixes) and >> so would be happy to see this go in. A few suggestions though: > Also, I think I needed to set $output_rolestats = 0 to get sensible > output (without the unnecessary role stuff). > > - Matthew