From: Don Slutz <dslutz@verizon.com>
To: Jan Beulich <JBeulich@suse.com>, Matthew Daley <mattjd@gmail.com>,
Don Slutz <dslutz@verizon.com>
Cc: Keir Fraser <keir@xen.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] Add scripts/get_maintainer.pl
Date: Mon, 14 Oct 2013 11:55:26 -0400 [thread overview]
Message-ID: <525C13EE.5070007@terremark.com> (raw)
In-Reply-To: <524EA7F702000078000F8CC3@nat28.tlf.novell.com>
How about this change:
From 43bd190b25e2c02d0323c9843b99aa4592b9a13c Mon Sep 17 00:00:00 2001
From: Don Slutz <dslutz@verizon.com>
Date: Mon, 14 Oct 2013 11:48:10 -0400
Subject: [PATCH 2/2] get_maintainer.pl: Drop 'supporter:THE REST' if any other supporter found.
Signed-off-by: Don Slutz <dslutz@verizon.com>
---
scripts/get_maintainer.pl | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 44e2532..8a44bf7 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -647,6 +647,18 @@ sub get_maintainers {
}
}
+ if ($#email_to > 0) {
+ my $do_shift = 0;
+ foreach my $email (@email_to) {
+ if ($email->[1] ne 'supporter:THE REST') {
+ $do_shift = 1;
+ last;
+ }
+ }
+ shift @email_to
+ if $do_shift;
+ }
+
foreach my $email (@email_to, @list_to) {
$email->[0] = deduplicate_email($email->[0]);
}
--
1.7.1
which makes the script more intelligent.
-Don Slutz
On 10/04/13 05:35, Jan Beulich wrote:
>>>> On 04.10.13 at 08:03, Matthew Daley <mattjd@gmail.com> wrote:
>> Also, speaking of adequate MAINTAINERS coverage, the last entry which
>> attempts to have Keir as a fallback for "everything else" actually
>> mean Keir is CC'd on everything using the script. This is because it
>> uses all matching regexes and not just the most specific. Perhaps this
>> entry needs to be commented out (leaving it their for manual
>> inspection), or removed entirely?
> Or the script be made more intelligent? After all, the entry is there
> for a reason...
>
> Jan
>
next prev parent reply other threads:[~2013-10-14 15:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 22:22 [PATCH] Add scripts/get_maintainer.pl Don Slutz
2013-10-04 6:03 ` Matthew Daley
2013-10-04 7:25 ` Matthew Daley
2013-10-14 15:53 ` Don Slutz
2013-10-30 6:52 ` Matthew Daley
2013-10-04 9:35 ` Jan Beulich
2013-10-14 15:55 ` Don Slutz [this message]
2013-10-31 19:06 ` Ian Campbell
2013-11-04 18:19 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525C13EE.5070007@terremark.com \
--to=dslutz@verizon.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=mattjd@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.