From: "H. Peter Anvin" <hpa@zytor.com>
To: David Cohen <david.a.cohen@linux.intel.com>,
tglx@linutronix.de, mingo@redhat.com
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
platform-driver-x86@vger.kernel.org,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
Subject: Re: [PATCH v3 08/10] intel_mid: Added custom handler for ipc devices
Date: Mon, 14 Oct 2013 09:04:39 -0700 [thread overview]
Message-ID: <525C1617.7090304@zytor.com> (raw)
In-Reply-To: <1381549404-22594-9-git-send-email-david.a.cohen@linux.intel.com>
On 10/11/2013 08:43 PM, David Cohen wrote:
> +
> + /*
> + * We need to call platform init of IPC devices to fill misc_pdata
> + * structure. It will be used in msic_init for initialization.
> + */
> + if (dev != NULL)
> + pdata = dev->get_platform_data(pentry);
> +
The Linux style usually prefers:
if (dev)
...
-hpa
next prev parent reply other threads:[~2013-10-14 16:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 3:43 [PATCH v3 00/10] rework arch/x86/platform/[mrst => intel-mid] David Cohen
2013-10-12 3:43 ` [PATCH v3 01/10] mrst: Fixed printk/pr_* related issues David Cohen
2013-10-12 3:43 ` [PATCH v3 02/10] mrst: Fixed indentation issues David Cohen
2013-10-12 3:43 ` [PATCH v3 03/10] mrst: Fixed checkpatch warnings David Cohen
2013-10-12 3:43 ` [PATCH v3 04/10] intel_mid: Renamed *mrst* to *intel_mid* David Cohen
2013-10-12 3:43 ` [PATCH v3 05/10] " David Cohen
2013-10-12 3:43 ` [PATCH v3 06/10] intel_mid: Refactored sfi_parse_devs() function David Cohen
2013-10-12 3:43 ` [PATCH v3 07/10] intel_mid: Added custom device_handler support David Cohen
2013-10-14 16:03 ` H. Peter Anvin
2013-10-14 16:16 ` Joe Perches
2013-10-14 16:30 ` H. Peter Anvin
2013-10-14 16:32 ` David Cohen
2013-10-14 16:30 ` H. Peter Anvin
2013-10-14 16:40 ` David Cohen
2013-10-12 3:43 ` [PATCH v3 08/10] intel_mid: Added custom handler for ipc devices David Cohen
2013-10-14 16:04 ` H. Peter Anvin [this message]
2013-10-14 16:33 ` David Cohen
2013-10-12 3:43 ` [PATCH v3 09/10] intel_mid: Moved board related code to a new file David Cohen
2013-10-12 3:43 ` [PATCH v3 10/10] intel_mid: Moved SFI related code to intel_mid_sfi.c David Cohen
2013-10-14 16:38 ` H. Peter Anvin
2013-10-14 16:47 ` David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525C1617.7090304@zytor.com \
--to=hpa@zytor.com \
--cc=david.a.cohen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.