From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Cohen <david.a.cohen@linux.intel.com>
Subject: Re: [PATCH v3 08/10] intel_mid: Added custom handler for ipc devices
Date: Mon, 14 Oct 2013 09:33:34 -0700
Message-ID: <525C1CDE.9020309@linux.intel.com>
References: <1381549404-22594-1-git-send-email-david.a.cohen@linux.intel.com> <1381549404-22594-9-git-send-email-david.a.cohen@linux.intel.com> <525C1617.7090304@zytor.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <platform-driver-x86-owner@vger.kernel.org>
Received: from mga11.intel.com ([192.55.52.93]:10269 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757049Ab3JNQaX (ORCPT
	<rfc822;platform-driver-x86@vger.kernel.org>);
	Mon, 14 Oct 2013 12:30:23 -0400
In-Reply-To: <525C1617.7090304@zytor.com>
Sender: platform-driver-x86-owner@vger.kernel.org
List-ID: <platform-driver-x86.vger.kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: tglx@linutronix.de, mingo@redhat.com, linux-kernel@vger.kernel.org, x86@kernel.org, platform-driver-x86@vger.kernel.org, Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

On 10/14/2013 09:04 AM, H. Peter Anvin wrote:
> On 10/11/2013 08:43 PM, David Cohen wrote:
>> +
>> +	/*
>> +	 * We need to call platform init of IPC devices to fill misc_pdata
>> +	 * structure. It will be used in msic_init for initialization.
>> +	 */
>> +	if (dev != NULL)
>> +		pdata = dev->get_platform_data(pentry);
>> +
>
> The Linux style usually prefers:
>
> 	if (dev)

Thanks. I'll change it on next patch set.

Br, David Cohen