From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Cohen Subject: Re: [PATCH v3 10/10] intel_mid: Moved SFI related code to intel_mid_sfi.c Date: Mon, 14 Oct 2013 09:47:00 -0700 Message-ID: <525C2004.1030604@linux.intel.com> References: <1381549404-22594-1-git-send-email-david.a.cohen@linux.intel.com> <1381549404-22594-11-git-send-email-david.a.cohen@linux.intel.com> <525C1E1C.9060306@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com ([134.134.136.20]:61032 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757034Ab3JNQnI (ORCPT ); Mon, 14 Oct 2013 12:43:08 -0400 In-Reply-To: <525C1E1C.9060306@zytor.com> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: "H. Peter Anvin" Cc: tglx@linutronix.de, mingo@redhat.com, linux-kernel@vger.kernel.org, x86@kernel.org, platform-driver-x86@vger.kernel.org, Kuppuswamy Sathyanarayanan On 10/14/2013 09:38 AM, H. Peter Anvin wrote: > On 10/11/2013 08:43 PM, David Cohen wrote: >> From: Kuppuswamy Sathyanarayanan >> >> Moved SFI specific parsing/handling code to intel_mid_sfi.c. This will enable >> us to reuse our intel-mid code for platforms that supports firmware interfaces >> other than SFI (like ACPI). >> >> Signed-off-by: Kuppuswamy Sathyanarayanan >> Signed-off-by: David Cohen >> --- >> arch/x86/include/asm/intel-mid.h | 1 + >> arch/x86/platform/intel-mid/Makefile | 5 +- >> arch/x86/platform/intel-mid/intel-mid.c | 450 -------------------------- >> arch/x86/platform/intel-mid/intel_mid_sfi.c | 485 ++++++++++++++++++++++++++++ >> 4 files changed, 489 insertions(+), 452 deletions(-) >> create mode 100644 arch/x86/platform/intel-mid/intel_mid_sfi.c >> > > Why not just sfi.c? It is already in a directly named intel-mid. > > I presume otherwise this is just code movement... I haven't verified > that, but it looked like it. Yes, it is and I agree sfi.c seems better. Changing it for next patch set too. Br, David Cohen > > -hpa >