From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVlaA-0006mw-Iy for qemu-devel@nongnu.org; Mon, 14 Oct 2013 13:05:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVla5-00066i-PA for qemu-devel@nongnu.org; Mon, 14 Oct 2013 13:05:26 -0400 Received: from smtp.polymtl.ca ([132.207.4.11]:33304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVla5-00063b-LA for qemu-devel@nongnu.org; Mon, 14 Oct 2013 13:05:21 -0400 Message-ID: <525C244A.6060503@polymtl.ca> Date: Mon, 14 Oct 2013 13:05:14 -0400 From: Mohamad Gebai MIME-Version: 1.0 References: <1380913658-23729-1-git-send-email-mohamad.gebai@polymtl.ca> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH v2 0/3] Fix UST backend for LTTng 2.x List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Cc: qemu-devel@nongnu.org Sorry for the delay, just submitted the updated documentation. Thanks, Mohamad On 13-10-07 08:36 AM, Alex Benn=C3=A9e wrote: > mohamad.gebai@gmail.com writes: > >> Version 2 >> >> * Fix tracepoint generation error in first version. >> * Avoid warnings and errors specific to LTTng ust 2.0. >> * If using LTTng ust 2.0, we can't avoid getting warnings because of t= he >> --warn-common option given to the linker. This is fixed in more rec= ent >> versions of LTTng ust. > Looking good. Builds for me now although I need to do some reading to > actually test it out. One omission is docs/tracing.txt gives examples > for the other tracing backend but just refers to "UST utilities should > be used to list, enable/disable, and dump traces.". Perhaps a few simpl= e > examples could be added to the document so people can at least confirm > everything is working as it should be. Otherwise I'm happy. > > Reviewed-by: Alex Benn=C3=A9e > >> Mohamad >> >> Mohamad Gebai (3): >> Fix configure script for LTTng 2.x >> Modified the tracetool framework for LTTng 2.x. >> Adapt Makefiles to the new LTTng ust interface. >> >> Makefile | 5 ++ >> configure | 9 ++-- >> scripts/tracetool/backend/events.py | 44 ++++++++++++++++ >> scripts/tracetool/backend/ust.py | 82 ++++++--------------= ---------- >> scripts/tracetool/format/ust_events_c.py | 30 +++++++++++ >> scripts/tracetool/format/ust_events_h.py | 57 ++++++++++++++++++++= + >> trace/Makefile.objs | 29 ++++++++++- >> 7 files changed, 183 insertions(+), 73 deletions(-) >> create mode 100644 scripts/tracetool/format/ust_events_c.py >> create mode 100644 scripts/tracetool/format/ust_events_h.py >