Re: [PATCH 12/16] xen/evtchn: support more than 4096 ports

[Boris Ostrovsky <boris.ostrovsky@oracle.com>]

On 10/08/2013 08:49 AM, David Vrabel wrote:
> From: David Vrabel <david.vrabel@citrix.com>
>
> Remove the check during unbind for NR_EVENT_CHANNELS as this limits
> support to less than 4096 ports.


This is an interface change, you will be returning a different type of 
error (ENOTCONN instead of EINVAL).

Why not check for xen_evtchn_nr_channels()?

-boris


>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> ---
>   drivers/xen/evtchn.c |    4 ----
>   1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c
> index 8b3a69a..1b0fc44 100644
> --- a/drivers/xen/evtchn.c
> +++ b/drivers/xen/evtchn.c
> @@ -416,10 +416,6 @@ static long evtchn_ioctl(struct file *file,
>   		if (copy_from_user(&unbind, uarg, sizeof(unbind)))
>   			break;
>   
> -		rc = -EINVAL;
> -		if (unbind.port >= NR_EVENT_CHANNELS)
> -			break;
> -
>   		rc = -ENOTCONN;
>   		evtchn = find_evtchn(u, unbind.port);
>   		if (!evtchn)