From: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
To: Jingbai Ma <jingbai.ma@hp.com>
Cc: bhe@redhat.com, nishimura@mxp.nes.nec.co.jp,
usui@mxm.nes.nec.co.jp, lisa.mitchell@hp.com, ruyang@redhat.com,
tachibana@mxm.nes.nec.co.jp, anderson@redhat.com,
chaowang@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp,
kexec@lists.infradead.org, vgoyal@redhat.com,
crash-utility@redhat.com
Subject: Re: [PATCH v3] makedumpfile: fix max_mapnr issue on system has over 44-bit addressing
Date: Tue, 15 Oct 2013 16:32:59 +0900 [thread overview]
Message-ID: <525CEFAB.1000303@jp.fujitsu.com> (raw)
In-Reply-To: <525CD97B.3070209@jp.fujitsu.com>
(2013/10/15 14:58), HATAYAMA Daisuke wrote:
> (2013/10/14 21:16), Jingbai Ma wrote:
> <cut>
>> @@ -2793,7 +2806,7 @@ initialize_bitmap_memory(void)
>> bmp->offset = bitmap_offset + bitmap_len / 2;
>> info->bitmap_memory = bmp;
>>
>> - max_sect_len = divideup(dh->max_mapnr, BITMAP_SECT_LEN);
>> + max_sect_len = divideup(kh->max_mapnr_64, BITMAP_SECT_LEN);
>> info->valid_pages = calloc(sizeof(ulong), max_sect_len);
>
> Ah, please here needs to be fixed, too. Here should have been
> used sizeof(int) but now sizeof(off_t) should be used.
>
This is wrong. Please ignore.
--
Thanks.
HATAYAMA, Daisuke
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-10-15 7:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 12:16 [PATCH v3] makedumpfile: fix max_mapnr issue on system has over 44-bit addressing Jingbai Ma
2013-10-15 5:58 ` HATAYAMA Daisuke
2013-10-15 7:32 ` HATAYAMA Daisuke [this message]
2013-10-15 7:55 ` Jingbai Ma
2013-10-15 8:22 ` HATAYAMA Daisuke
2013-10-15 8:29 ` Jingbai Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525CEFAB.1000303@jp.fujitsu.com \
--to=d.hatayama@jp.fujitsu.com \
--cc=anderson@redhat.com \
--cc=bhe@redhat.com \
--cc=chaowang@redhat.com \
--cc=crash-utility@redhat.com \
--cc=jingbai.ma@hp.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=lisa.mitchell@hp.com \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=ruyang@redhat.com \
--cc=tachibana@mxm.nes.nec.co.jp \
--cc=usui@mxm.nes.nec.co.jp \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.