All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Avinash kumar <avi.kp.137@gmail.com>
Cc: davem@davemloft.net, michal.simek@xilinx.com, lars@metafoo.de,
	RHoover@digilentinc.com, netdev@vger.kernel.org
Subject: Re: [PATCH] drivers: net: phy: marvell.c: removed checkpatch.pl warnings
Date: Tue, 15 Oct 2013 21:12:40 +0400	[thread overview]
Message-ID: <525D7788.3010803@cogentembedded.com> (raw)
In-Reply-To: <1380514004-8701-1-git-send-email-avi.kp.137@gmail.com>

Hello.

On 09/30/2013 08:06 AM, Avinash kumar wrote:

> removes following warnings-
> drivers/net/phy/marvell.c:37: WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> drivers/net/phy/marvell.c:39: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

> Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>
> ---
>   drivers/net/phy/marvell.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index 2e91477..2e3c778e 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -34,9 +34,9 @@
>   #include <linux/marvell_phy.h>
>   #include <linux/of.h>
>
> -#include <asm/io.h>
> +#include <linux/io.h>
>   #include <asm/irq.h>
> -#include <asm/uaccess.h>
> +#include <linux/uaccess.h>

    You should move these #include's to the group of <linux/> #include's  now.

WBR, Sergei

      parent reply	other threads:[~2013-10-15 17:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30  4:06 [PATCH] drivers: net: phy: marvell.c: removed checkpatch.pl warnings Avinash kumar
2013-10-01  5:15 ` David Miller
2013-10-15 17:12 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525D7788.3010803@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=RHoover@digilentinc.com \
    --cc=avi.kp.137@gmail.com \
    --cc=davem@davemloft.net \
    --cc=lars@metafoo.de \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.