From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 14/18] net: usb: use wrapper functions of net_ratelimit() to simplify code Date: Tue, 15 Oct 2013 23:06:04 +0400 Message-ID: <525D921C.2030709@cogentembedded.com> References: <1381837514-50660-1-git-send-email-wangkefeng.wang@huawei.com> <1381837514-50660-15-git-send-email-wangkefeng.wang@huawei.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1381837514-50660-15-git-send-email-wangkefeng.wang@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Kefeng Wang Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "David S. Miller" , Pablo Neira Ayuso , Stephen Hemminger , Johannes Berg , "John W. Linville" , Stanislaw Gruszka , Johannes Berg , Francois Romieu , Ben Hutchings , Chas Williams , Marc Kleine-Budde , Samuel Ortiz , Paul Mackerras , Oliver Neukum , Konrad Rzeszutek Wilk , Boris Ostrovsky , David Vrabel , Rusty Russell , "Michael S. Tsirkin" , netfilter@vger.kernel Hello. On 10/15/2013 03:45 PM, Kefeng Wang wrote: > net_ratelimited_function() is called to simplify code. > Signed-off-by: Kefeng Wang > --- > drivers/net/usb/usbnet.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > index bf94e10..edf81de 100644 > --- a/drivers/net/usb/usbnet.c > +++ b/drivers/net/usb/usbnet.c > @@ -450,8 +450,8 @@ void usbnet_defer_kevent (struct usbnet *dev, int work) > { > set_bit (work, &dev->flags); > if (!schedule_work (&dev->kevent)) { > - if (net_ratelimit()) > - netdev_err(dev->net, "kevent %d may have been dropped\n", work); > + net_ratelimited_function(netdev_err, dev->net, > + "kevent %d may have been dropped\n", work); The continuation line should start under 'netdev_err'. Same about the other patches where you didn't change the indentation of the continuation lines though you should have. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lb0-f173.google.com ([209.85.217.173]:37316 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757504Ab3JOTHJ (ORCPT ); Tue, 15 Oct 2013 15:07:09 -0400 Received: by mail-lb0-f173.google.com with SMTP id o14so7193740lbi.18 for ; Tue, 15 Oct 2013 12:07:08 -0700 (PDT) Message-ID: <525D921C.2030709@cogentembedded.com> (sfid-20131015_210741_911733_2F3AF04C) Date: Tue, 15 Oct 2013 23:06:04 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Kefeng Wang CC: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "David S. Miller" , Pablo Neira Ayuso , Stephen Hemminger , Johannes Berg , "John W. Linville" , Stanislaw Gruszka , Johannes Berg , Francois Romieu , Ben Hutchings , Chas Williams , Marc Kleine-Budde , Samuel Ortiz , Paul Mackerras , Oliver Neukum , Konrad Rzeszutek Wilk , Boris Ostrovsky , David Vrabel , Rusty Russell , "Michael S. Tsirkin" , netfilter@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, guohanjun@huawei.com Subject: Re: [PATCH 14/18] net: usb: use wrapper functions of net_ratelimit() to simplify code References: <1381837514-50660-1-git-send-email-wangkefeng.wang@huawei.com> <1381837514-50660-15-git-send-email-wangkefeng.wang@huawei.com> In-Reply-To: <1381837514-50660-15-git-send-email-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello. On 10/15/2013 03:45 PM, Kefeng Wang wrote: > net_ratelimited_function() is called to simplify code. > Signed-off-by: Kefeng Wang > --- > drivers/net/usb/usbnet.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > index bf94e10..edf81de 100644 > --- a/drivers/net/usb/usbnet.c > +++ b/drivers/net/usb/usbnet.c > @@ -450,8 +450,8 @@ void usbnet_defer_kevent (struct usbnet *dev, int work) > { > set_bit (work, &dev->flags); > if (!schedule_work (&dev->kevent)) { > - if (net_ratelimit()) > - netdev_err(dev->net, "kevent %d may have been dropped\n", work); > + net_ratelimited_function(netdev_err, dev->net, > + "kevent %d may have been dropped\n", work); The continuation line should start under 'netdev_err'. Same about the other patches where you didn't change the indentation of the continuation lines though you should have. WBR, Sergei