From: David Cohen <david.a.cohen@linux.intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: mingo@redhat.com, tglx@linutronix.de, x86@kernel.org,
linux-kernel@vger.kernel.org,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
Subject: Re: [PATCH v4 12/12] intel_mid: Moved board related code to a new file
Date: Tue, 15 Oct 2013 20:59:35 -0700 [thread overview]
Message-ID: <525E0F27.4030502@linux.intel.com> (raw)
In-Reply-To: <525DE197.5040607@zytor.com>
On 10/15/2013 05:45 PM, H. Peter Anvin wrote:
> On 10/15/2013 04:53 PM, David Cohen wrote:
>> On 10/15/2013 04:44 PM, H. Peter Anvin wrote:
>>> On 10/15/2013 04:42 PM, David Cohen wrote:
>>>>
>>>> +#define intel_mid_sfi_dev(i) \
>>>> + static const struct devs_id *__intel_mid_sfi_##i##_dev __used \
>>>> + __attribute__((__section__(".x86_intel_mid_dev.init"))) = &i
>>>> +
>>>
>>> Any reason to not just call this "sfi_device()" or something similar?
>>> "Intel MID SFI" seems a bit redundant...
>>
>> I had the same though. But struct devs_id is defined by asm/intel-mid.h.
>> This function is not meant to be used by any other user beside
>> intel-mid.
>> But I can change if you prefer.
>>
>
> Hm, I guess it doesn't really matter. After all, no other devices will
> probably ever see SFI (we hope).
I hope too :)
Let me send a new version with this change.
Br, David Cohen
prev parent reply other threads:[~2013-10-16 4:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 23:42 [PATCH v4 00/12] rework arch/x86/platform/[mrst => intel-mid] David Cohen
2013-10-15 23:42 ` [PATCH v4 01/12] mrst: Fixed printk/pr_* related issues David Cohen
2013-10-15 23:42 ` [PATCH v4 02/12] mrst: Fixed indentation issues David Cohen
2013-10-15 23:42 ` [PATCH v4 03/12] mrst: Fixed checkpatch warnings David Cohen
2013-10-15 23:42 ` [PATCH v4 04/12] intel_mid: Renamed *mrst* to *intel_mid* David Cohen
2013-10-15 23:42 ` [PATCH v4 05/12] " David Cohen
2013-10-15 23:42 ` [PATCH v4 06/12] intel_mid: Refactored sfi_parse_devs() function David Cohen
2013-10-15 23:42 ` [PATCH v4 07/12] intel_mid: Added custom device_handler support David Cohen
2013-10-15 23:42 ` [PATCH v4 08/12] intel_mid: Added custom handler for ipc devices David Cohen
2013-10-15 23:42 ` [PATCH v4 09/12] intel_mid: Moved SFI related code to sfi.c David Cohen
2013-10-15 23:42 ` [PATCH v4 10/12] intel-mid: sfi: allow struct devs_id.get_platform_data to be NULL David Cohen
2013-10-15 23:42 ` [PATCH v4 11/12] x86: intel-mid: add section for sfi device table David Cohen
2013-10-15 23:42 ` [PATCH v4 12/12] intel_mid: Moved board related code to a new file David Cohen
2013-10-15 23:44 ` H. Peter Anvin
2013-10-15 23:53 ` David Cohen
2013-10-16 0:45 ` H. Peter Anvin
2013-10-16 3:59 ` David Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525E0F27.4030502@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.