Re: [PATCH 2/2][RESEND] scsi_dh_alua: ALUA handler attach should succeed while TPG is transitioning

[Hannes Reinecke <hare@suse.de>]

On 10/15/2013 05:52 PM, Stewart, Sean wrote:
> During testing, it was discovered that when a device tries to attach to the alua handler while in TPG
> state of transitioning, the alua_rtpg function will wait for it to exit the state before allowing it
> to continue. As a result, if the 60 second timeout expires, the alua handler will not attach to the
> device.
> 
> To fix this, I have introduced an input argument to alua_rtpg called wait_for_transition.  The idea is
> that it will wait for the transition to complete before an activation (because the current TPG state has
> some bearing in that case), but during a discovery if it is transitioning, it will not wait, and will
> store the state as standby for the time being.
> 
> I believe the precedent exists for this from commit c0d289b3e59577532c45ee9110ef81bd7b341272
> Since if the device reports a state of transitioning, it can transition to other more valid states, and
> it has been established TPGS is supported on the device, if it is attaching.
> 
> Signed-off-by: Sean Stewart <Sean.Stewart@netapp.com>

Hmm. Looks like you're correct.

Acked-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html