All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v8 1/2] I2C: Zynq: Support for 0-length register address
Date: Wed, 16 Oct 2013 11:11:23 +0200	[thread overview]
Message-ID: <525E583B.6040701@monstr.eu> (raw)
In-Reply-To: <525E4D3A.3080702@denx.de>

On 10/16/2013 10:24 AM, Heiko Schocher wrote:
> Hello Michael,
> 
> Am 15.10.2013 22:23, schrieb Michael Burr:
>>> Fixed bug with alen == 0 in 'i2c_write', 'i2c_read'
>> Further minor corrections:
>>> Write 'address' register before 'data' register.
>>> Write 'transfer_size' register before 'address' register.
>>
>> Signed-off-by: Michael Burr <michael.burr@logicpd.com>
>> Cc: Heiko Schocher <hs@denx.de>
>> Cc: Michal Simek <monstr@monstr.eu>
>>
>> ---
>> Tested:
>> Xilinx ZC702 eval board.
>> Write and read registers with addresses of length 0 and 1.
>>
>> Change history:
>>> v2: put this in a series instead of by itself
>>> v3: fixed formatting problem in patch message
>>> v4: _really_ fixed this time!
>>> v5: yet another try
>>> v6: one more time
>>> v7: again
>>  > v8: After trying many times, I cannot get Patchwork to properly understand the diff in this message. As a workaround, please accept the diff in my patch of 2013-09-24, titled "[U-Boot] I2C: Zynq: Support for 0-length register address", which is 100%
>> equivalent to the patch in this message (1/2). It should still be applied before the patch in the second message (2/2).
> 
> Hmm.. please try to post a correct version of this patch, as I not
> really want to search the correct patch ... I am sure I will pick up
> the wrong version and I cannot test anything.
> 
> Thanks!
> 
> Hmm.. if you have problems with your commit message, you can reedit
> it:
> - get the commit id before your commit you want to edit
> - "git rebase -i commit-id"
>   -> you get a list of commits, see for help maybe here:
>      https://help.github.com/articles/interactive-rebase
> 
> Please remove the ">" in your commit message ... maybe this confuses
> patchwork ...

Albert is right. Just use patman -n to see your patches to get it done
correctly and then just use patman for sending.
There is nice README which describes everything what you need.

Thanks,
Michal



-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131016/dcb79f7f/attachment.pgp>

  reply	other threads:[~2013-10-16  9:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15 20:23 [U-Boot] [PATCH v8 0/2] I2C: Zynq Michael Burr
2013-10-15 20:23 ` [U-Boot] [PATCH v8 1/2] I2C: Zynq: Support for 0-length register address Michael Burr
2013-10-15 20:23   ` [U-Boot] [PATCH v8 2/2] I2C: Zynq: Adapt this driver to the new model Michael Burr
2013-10-16  8:24   ` [U-Boot] [PATCH v8 1/2] I2C: Zynq: Support for 0-length register address Heiko Schocher
2013-10-16  9:11     ` Michal Simek [this message]
2013-10-15 20:42 ` [U-Boot] [PATCH v8 0/2] I2C: Zynq Albert ARIBAUD
2013-10-16  7:58 ` Heiko Schocher
2013-10-17 10:43   ` Jagan Teki
2013-10-17 11:11     ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525E583B.6040701@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.