From: Rajendra Nayak <rnayak@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: OMAP5: Add i2c aliases
Date: Wed, 16 Oct 2013 17:07:42 +0530 [thread overview]
Message-ID: <525E7A86.4090507@ti.com> (raw)
In-Reply-To: <1381856405-30970-1-git-send-email-nm@ti.com>
On Tuesday 15 October 2013 10:30 PM, Nishanth Menon wrote:
> Currently, i2c1 and i2c5 defer probe due to pinctrl dependencies.
> This changes the i2c ID each bus is registered with in i2c-dev
> interface.
>
> As a result of this, many userspace tools break and there is no
> consistent manner to fix the same if the i2c dev interface have no
> consistent numbering. Provide alias to allow ordering the i2c devices
> correctly.
This looks good Nishanth. Shouldn't we just go ahead and fix these for
all OMAPs/AMxx devices which would have the same problem as OMAP5 ;)
Acked-by: Rajendra Nayak <rnayak@ti.com>
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> arch/arm/boot/dts/omap5.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index e18ee7e..8970deb 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -21,6 +21,11 @@
> interrupt-parent = <&gic>;
>
> aliases {
> + i2c0 = &i2c1;
> + i2c1 = &i2c2;
> + i2c2 = &i2c3;
> + i2c3 = &i2c4;
> + i2c4 = &i2c5;
> serial0 = &uart1;
> serial1 = &uart2;
> serial2 = &uart3;
>
WARNING: multiple messages have this Message-ID (diff)
From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: OMAP5: Add i2c aliases
Date: Wed, 16 Oct 2013 17:07:42 +0530 [thread overview]
Message-ID: <525E7A86.4090507@ti.com> (raw)
In-Reply-To: <1381856405-30970-1-git-send-email-nm@ti.com>
On Tuesday 15 October 2013 10:30 PM, Nishanth Menon wrote:
> Currently, i2c1 and i2c5 defer probe due to pinctrl dependencies.
> This changes the i2c ID each bus is registered with in i2c-dev
> interface.
>
> As a result of this, many userspace tools break and there is no
> consistent manner to fix the same if the i2c dev interface have no
> consistent numbering. Provide alias to allow ordering the i2c devices
> correctly.
This looks good Nishanth. Shouldn't we just go ahead and fix these for
all OMAPs/AMxx devices which would have the same problem as OMAP5 ;)
Acked-by: Rajendra Nayak <rnayak@ti.com>
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> arch/arm/boot/dts/omap5.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index e18ee7e..8970deb 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -21,6 +21,11 @@
> interrupt-parent = <&gic>;
>
> aliases {
> + i2c0 = &i2c1;
> + i2c1 = &i2c2;
> + i2c2 = &i2c3;
> + i2c3 = &i2c4;
> + i2c4 = &i2c5;
> serial0 = &uart1;
> serial1 = &uart2;
> serial2 = &uart3;
>
next prev parent reply other threads:[~2013-10-16 11:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 17:00 [PATCH] ARM: dts: OMAP5: Add i2c aliases Nishanth Menon
2013-10-15 17:00 ` Nishanth Menon
2013-10-15 17:00 ` Nishanth Menon
2013-10-16 11:37 ` Rajendra Nayak [this message]
2013-10-16 11:37 ` Rajendra Nayak
2013-10-16 12:58 ` Nishanth Menon
2013-10-16 12:58 ` Nishanth Menon
2013-10-16 20:21 ` [PATCH V2 0/2] ARM: dts: OMAP2+: add " Nishanth Menon
2013-10-16 20:21 ` Nishanth Menon
2013-10-16 20:21 ` Nishanth Menon
2013-10-16 20:21 ` [PATCH V2 1/2] ARM: dts: OMAP3+: Add " Nishanth Menon
2013-10-16 20:21 ` Nishanth Menon
2013-10-16 20:21 ` Nishanth Menon
2013-10-16 20:21 ` [PATCH V2 2/2] ARM: dts: AM33xx+: " Nishanth Menon
2013-10-16 20:21 ` Nishanth Menon
2013-10-16 20:21 ` Nishanth Menon
2013-10-21 9:18 ` [PATCH V2 0/2] ARM: dts: OMAP2+: add " Rajendra Nayak
2013-10-21 9:18 ` Rajendra Nayak
2013-10-21 9:18 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525E7A86.4090507@ti.com \
--to=rnayak@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.