From: Ian Abbott <abbotti@mev.co.uk>
To: Dhanunjaya <dhanunjaya.matrix@gmail.com>,
Ian Abbott <ian.abbott@mev.co.uk>,
"hsweeten@visionengravers.com" <hsweeten@visionengravers.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"wfp5p@virginia.edu" <wfp5p@virginia.edu>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: comedi: fix semicolon coding style issue in ni_660x.c
Date: Wed, 16 Oct 2013 15:07:17 +0100 [thread overview]
Message-ID: <525E9D95.7040304@mev.co.uk> (raw)
In-Reply-To: <1381927094-13457-1-git-send-email-dhanunjaya.matrix@gmail.com>
On 2013-10-16 13:38, Dhanunjaya wrote:
> This is a patch to the ni_660x.c file that fixes up a semicolon warning
> found by the checkpatch.pl tool
> ---
> drivers/staging/comedi/drivers/ni_660x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c
> index 3607336..95bb432 100644
> --- a/drivers/staging/comedi/drivers/ni_660x.c
> +++ b/drivers/staging/comedi/drivers/ni_660x.c
> @@ -28,7 +28,7 @@
> *
> * Encoders work. PulseGeneration (both single pulse and pulse train)
> * works. Buffered commands work for input but not output.
> - *
> + *
> * References:
> * DAQ 660x Register-Level Programmer Manual (NI 370505A-01)
> * DAQ 6601/6602 User Manual (NI 322137B-01)
> @@ -1232,7 +1232,7 @@ static int ni_660x_auto_attach(struct comedi_device *dev,
> s->type = COMEDI_SUBD_COUNTER;
> s->subdev_flags =
> SDF_READABLE | SDF_WRITABLE | SDF_LSAMPL |
> - SDF_CMD_READ /* | SDF_CMD_WRITE */ ;
> + SDF_CMD_READ; /* | SDF_CMD_WRITE */
> s->n_chan = 3;
> s->maxdata = 0xffffffff;
> s->insn_read = ni_660x_GPCT_rinsn;
>
Looks good!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2013-10-16 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 12:38 [PATCH] Staging: comedi: fix semicolon coding style issue in ni_660x.c Dhanunjaya
2013-10-16 14:07 ` Ian Abbott [this message]
2013-10-16 19:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525E9D95.7040304@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=dhanunjaya.matrix@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.