From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Bard Liao <bardliao@realtek.com>,
Stephen Warren <swarren@nvidia.com>
Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org,
Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH 1/2] ASoC: rt5640: Power down LDO while suspended
Date: Wed, 16 Oct 2013 11:47:34 -0600 [thread overview]
Message-ID: <525ED136.9040605@wwwdotorg.org> (raw)
In-Reply-To: <1381941215-29031-1-git-send-email-broonie@kernel.org>
On 10/16/2013 10:33 AM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> If we have control over the LDO then disable it during suspend; the device
> is already being put into reset so will be non-functional over suspend
> anyway and this will save a small amount of power.
The series,
Tested-by: Stephen Warren <swarren@nvidia.com>
On Tegra Beaver and Dalmore boards. As you may have noticed, Tegra audio
doesn't work after resume at the moment, but that's true irrespective of
these patches, and I believe is a problem without our DMA or I2S
drivers, and nothing to do with the CODEC. The CODEC certainly still
responds to I2C accesses (e.g. triggered by alsamixer) after this patch,
and wouldn't if the LDO1_EN GPIO wasn't correctly set.
prev parent reply other threads:[~2013-10-16 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 16:33 [PATCH 1/2] ASoC: rt5640: Power down LDO while suspended Mark Brown
2013-10-16 16:33 ` [PATCH 2/2] ASoC: rt5640: Don't go to standby on resume Mark Brown
2013-10-16 17:47 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525ED136.9040605@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.