All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Laxman Dewangan
	<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 1/2] spi/tegra20-slink: Crude refactoring to use core message parsing
Date: Wed, 16 Oct 2013 15:41:51 -0600	[thread overview]
Message-ID: <525F081F.1080601@wwwdotorg.org> (raw)
In-Reply-To: <1381957255-24344-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

On 10/16/2013 03:00 PM, Mark Brown wrote:
> From: Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> 
> This is a half done conversion with minimal code reorganisation provided
> for bisection purposes. A further patch will move the first transfer
> preparation into tegra_slink_prepare_message().

> diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c

> -static int tegra_slink_transfer_one_message(struct spi_master *master,
> -			struct spi_message *msg)
...
> -		msg->actual_length += xfer->len;
> -		if (xfer->cs_change && xfer->delay_usecs) {
> -			tegra_slink_writel(tspi, tspi->def_command_reg,
> -					SLINK_COMMAND);
> -			udelay(xfer->delay_usecs);
> -		}

That chunk didn't seem to end up anywhere else. Is that expected?

  parent reply	other threads:[~2013-10-16 21:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16 21:00 [PATCH 1/2] spi/tegra20-slink: Crude refactoring to use core message parsing Mark Brown
     [not found] ` <1381957255-24344-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-10-16 21:00   ` [PATCH 2/2] spi/tegra20-slink: Move first transfer preparation to prepare_message Mark Brown
2013-10-16 21:41   ` Stephen Warren [this message]
     [not found]     ` <525F081F.1080601-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-16 22:02       ` [PATCH 1/2] spi/tegra20-slink: Crude refactoring to use core message parsing Mark Brown
2013-10-16 22:08   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525F081F.1080601@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.