Re: [PATCH] connman: ignore the networking device which nfs for rootfs is working on

[Rongqing Li <rongqing.li@windriver.com>]

On 10/16/2013 06:08 PM, Enrico Scholz wrote:
> Rongqing Li <rongqing.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
> writes:
>
>>>>> ConditionKernelCommandLine!=root=/dev/nfs
>>>>>>>
>>>>>
>>>>> What is your meaning?
>>> That's you are creating a huge script that does something built into systemd.
>>>
>>
>>
>> Yes, I can not find a way to avoid to that,
>>
>> Do you have any advice?
>
> I would split the cmdline generation into a dedicated one-shot service;
> e.g. modify the original connman.service to have something like
>
>    [Service]
>    EnvironmentFile = -/run/connmand.env
>    ExecStart=/usr/sbin/connmand -n ${CONNMAND_OPTS}
>
>
> The '/run/connmand.env' is created by a service with
>
>    [Unit]
>    Before = connman.service
>    ConditionKernelCommandLine!=root=/dev/nfs
>
>    [Service]
>    Type = oneshot
>    ExecStart = /usr/sbin/create-run-connmand.env
>
>    [Install]
>    WantedBy = connman.service
>
>
>


I test your method, but failed to start connmand,
it always report "hand over timeout", I think
it is caused by which the script run slow.


But I will follow your method, create two service.
the connman.service is run only when
ConditionKernelCommandLine!=root=/dev/nfs

other connman-nfs.service, which will start the
script to compute the ignored interface, is run
when ConditionKernelCommandLine=root=/dev/nfs


-Roy




> Enrico
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

-- 
Best Reagrds,
Roy | RongQing Li