All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] sh: ecovec: Update to new I2C framework
Date: Thu, 17 Oct 2013 09:37:27 +0200	[thread overview]
Message-ID: <525F93B7.4030002@denx.de> (raw)
In-Reply-To: <1381994312-10728-3-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>

Hello Nobuhiro,

Am 17.10.2013 09:18, schrieb Nobuhiro Iwamatsu:
> Ecovec uses sh_i2c driver. sh_i2c driver updated to new I2C framwork.
> This updates ecovec to this change.
>
> Signed-off-by: Nobuhiro Iwamatsu<nobuhiro.iwamatsu.yj@renesas.com>
> ---
>   board/renesas/ecovec/ecovec.c |  4 ++--
>   include/configs/ecovec.h      | 15 +++++++--------
>   2 files changed, 9 insertions(+), 10 deletions(-)

Could you sqash this patch into http://patchwork.ozlabs.org/patch/284106
so we get no problems with "git bisect".

Beside of that only one comment:

> diff --git a/board/renesas/ecovec/ecovec.c b/board/renesas/ecovec/ecovec.c
> index e2d365a..4289d2d 100644
> --- a/board/renesas/ecovec/ecovec.c
> +++ b/board/renesas/ecovec/ecovec.c
> @@ -57,8 +57,8 @@ int board_late_init(void)
>
>   	outl(inl(MSTPCR2)&  ~0x10000000, MSTPCR2);
>
> -	i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
> -	i2c_set_bus_num(CONFIG_SYS_I2C_MODULE); /* Use I2C 1 */
> +	i2c_init(CONFIG_SYS_I2C_SH_SPEED1, CONFIG_SYS_I2C_SLAVE);
> +	i2c_set_bus_num(1); /* Use I2C 1 */

same comment as for your patch for the kzm9g board, remove i2c_init()
call, as it is no longer necessary, thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2013-10-17  7:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17  7:18 [U-Boot] [PATCH 1/3] i2c: sh_i2c: Update to new CONFIG_SYS_I2C framework Nobuhiro Iwamatsu
2013-10-17  7:18 ` [U-Boot] [PATCH 2/3] arm: kzm9g: Update to new I2C framework Nobuhiro Iwamatsu
2013-10-17  7:37   ` Heiko Schocher
2013-10-21  9:36     ` Nobuhiro Iwamatsu
2013-10-17  7:18 ` [U-Boot] [PATCH 3/3] sh: ecovec: " Nobuhiro Iwamatsu
2013-10-17  7:37   ` Heiko Schocher [this message]
2013-10-21  9:40     ` Nobuhiro Iwamatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525F93B7.4030002@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.