From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?44Kr44Kq44CA44Of44Oz44CA44OS44Kn44OD44OX?=  <cm-hiep@jinso.co.jp>
Date: Thu, 17 Oct 2013 08:04:14 +0000
Subject: Re: [PATCH 1/2] ARM: shmobile: r8a7790: add QSPI support
Message-Id: <525F99FE.60502@jinso.co.jp>
List-Id: <linux-sh.vger.kernel.org>
References: <1368173119-27345-2-git-send-email-horms+renesas@verge.net.au>
In-Reply-To: <1368173119-27345-2-git-send-email-horms+renesas@verge.net.au>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-sh@vger.kernel.org

Hi Morimoto-san

Thanks for your replying!

>>>> +void __init r8a7790_add_qspi_device(struct rspi_plat_data *pdata)
>>>> +{
>>>> +	platform_device_register_resndata(
>>>> +		&platform_bus, "qspi", 0,
>>>> +		qspi_resources, ARRAY_SIZE(qspi_resources),
>>>> +		pdata, sizeof(*pdata));
>>>> +}
>>> Please use -1 ID, and use just "qspi", instead of "qspi.0"
>> I have tried to use -1 ID instead of 0, and then I saw that QSPI did not
>> contact to Flash Memory.
>> I found that in QSPI driver, ID is assigned to bus number:
>> master->bus_num = pdev->id.
>> So I wonder how to modify it.
> According to spi_register_master(), bus_num = -1 seems not problem.
> Did you exchanged clock name ?
I saw that in "struct spi_board_info" has defined bus_num is u16
so I'm afraid if is -1 ID, master->bus_num did not match to bus_num in 
board_info.

Thanks,

Hiep.