From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver. Date: Thu, 17 Oct 2013 07:15:03 -0500 Message-ID: <525FD4C7.3050806@tabi.org> References: <1382000477-17304-1-git-send-email-Li.Xiubo@freescale.com> <1382000477-17304-2-git-send-email-Li.Xiubo@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from muin.pair.com (muin.pair.com [209.68.1.55]) by alsa0.perex.cz (Postfix) with ESMTP id 2A45A261A61 for ; Thu, 17 Oct 2013 14:15:08 +0200 (CEST) In-Reply-To: <1382000477-17304-2-git-send-email-Li.Xiubo@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Xiubo Li , r65073@freescale.com, lgirdwood@gmail.com, broonie@kernel.org Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org, linux-doc@vger.kernel.org, tiwai@suse.de, b18965@freescale.com, LW@KARO-electronics.de, linux@arm.linux.org.uk, b42378@freescale.com, oskar@scara.com, grant.likely@linaro.org, devicetree@vger.kernel.org, ian.campbell@citrix.com, pawel.moll@arm.com, swarren@wwwdotorg.org, rob.herring@calxeda.com, linux-arm-kernel@lists.infradead.org, fabio.estevam@freescale.com, linux-kernel@vger.kernel.org, rob@landley.net, r64188@freescale.com, shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org List-Id: alsa-devel@alsa-project.org Xiubo Li wrote: > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + sai->base = devm_ioremap_resource(&pdev->dev, res); Why not use of_iomap()? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muin.pair.com (muin.pair.com [209.68.1.55]) by ozlabs.org (Postfix) with ESMTP id BB4A22C00C3 for ; Thu, 17 Oct 2013 23:15:08 +1100 (EST) Message-ID: <525FD4C7.3050806@tabi.org> Date: Thu, 17 Oct 2013 07:15:03 -0500 From: Timur Tabi MIME-Version: 1.0 To: Xiubo Li , r65073@freescale.com, lgirdwood@gmail.com, broonie@kernel.org Subject: Re: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver. References: <1382000477-17304-1-git-send-email-Li.Xiubo@freescale.com> <1382000477-17304-2-git-send-email-Li.Xiubo@freescale.com> In-Reply-To: <1382000477-17304-2-git-send-email-Li.Xiubo@freescale.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org, linux-doc@vger.kernel.org, tiwai@suse.de, b18965@freescale.com, perex@perex.cz, LW@KARO-electronics.de, linux@arm.linux.org.uk, b42378@freescale.com, oskar@scara.com, grant.likely@linaro.org, devicetree@vger.kernel.org, ian.campbell@citrix.com, pawel.moll@arm.com, swarren@wwwdotorg.org, rob.herring@calxeda.com, linux-arm-kernel@lists.infradead.org, fabio.estevam@freescale.com, linux-kernel@vger.kernel.org, rob@landley.net, r64188@freescale.com, shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Xiubo Li wrote: > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + sai->base = devm_ioremap_resource(&pdev->dev, res); Why not use of_iomap()? From mboxrd@z Thu Jan 1 00:00:00 1970 From: timur@tabi.org (Timur Tabi) Date: Thu, 17 Oct 2013 07:15:03 -0500 Subject: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver. In-Reply-To: <1382000477-17304-2-git-send-email-Li.Xiubo@freescale.com> References: <1382000477-17304-1-git-send-email-Li.Xiubo@freescale.com> <1382000477-17304-2-git-send-email-Li.Xiubo@freescale.com> Message-ID: <525FD4C7.3050806@tabi.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Xiubo Li wrote: > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + sai->base = devm_ioremap_resource(&pdev->dev, res); Why not use of_iomap()? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755292Ab3JQMPK (ORCPT ); Thu, 17 Oct 2013 08:15:10 -0400 Received: from muin.pair.com ([209.68.1.55]:61419 "EHLO muin.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754638Ab3JQMPI (ORCPT ); Thu, 17 Oct 2013 08:15:08 -0400 Message-ID: <525FD4C7.3050806@tabi.org> Date: Thu, 17 Oct 2013 07:15:03 -0500 From: Timur Tabi User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:24.0) Gecko/20100101 Firefox/24.0 SeaMonkey/2.21 MIME-Version: 1.0 To: Xiubo Li , r65073@freescale.com, lgirdwood@gmail.com, broonie@kernel.org CC: r64188@freescale.com, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org, ian.campbell@citrix.com, rob@landley.net, linux@arm.linux.org.uk, perex@perex.cz, tiwai@suse.de, grant.likely@linaro.org, fabio.estevam@freescale.com, LW@KARO-electronics.de, oskar@scara.com, shawn.guo@linaro.org, b42378@freescale.com, b18965@freescale.com, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver. References: <1382000477-17304-1-git-send-email-Li.Xiubo@freescale.com> <1382000477-17304-2-git-send-email-Li.Xiubo@freescale.com> In-Reply-To: <1382000477-17304-2-git-send-email-Li.Xiubo@freescale.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Xiubo Li wrote: > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + sai->base = devm_ioremap_resource(&pdev->dev, res); Why not use of_iomap()?