All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] rcar-hpbdma: add max transfer size
Date: Thu, 17 Oct 2013 13:02:29 +0000	[thread overview]
Message-ID: <525FDFE5.3070703@cogentembedded.com> (raw)
In-Reply-To: <87ioww187v.wl%kuninori.morimoto.gx@renesas.com>

Hello.

On 17-10-2013 14:51, Kuninori Morimoto wrote:

> shdma_chan_probe() can set max transfer size,
> but it will be PAGE_SIZE with out this patch.

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>   drivers/dma/sh/rcar-hpbdma.c |    2 ++
>   1 file changed, 2 insertions(+)

> diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c
> index ebad845..b1ae8dc 100644
> --- a/drivers/dma/sh/rcar-hpbdma.c
> +++ b/drivers/dma/sh/rcar-hpbdma.c
> @@ -510,6 +510,8 @@ static int hpb_dmae_chan_probe(struct hpb_dmae_device *hpbdev, int id)
>   	}
>
>   	schan = &new_hpb_chan->shdma_chan;
> +	schan->max_xfer_len = HPB_DMA_TCR_MAX + 1;
> +

    +1 is not correct here, HPB_DMA_TCR_MAX is #define'd as 16 MiB, not 16 MiB 
- 1.

WBR, Sergei


  reply	other threads:[~2013-10-17 13:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17 10:51 [PATCH 1/3] rcar-hpbdma: add max transfer size Kuninori Morimoto
2013-10-17 13:02 ` Sergei Shtylyov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-10-17 10:50 [PATCH 0/3] rcar-hpbdma: fixup patches for double plane Kuninori Morimoto
2013-10-29  6:51 ` Kuninori Morimoto
2013-10-29  6:52   ` [PATCH 1/3] rcar-hpbdma: add max transfer size Kuninori Morimoto
2013-10-29  6:52     ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525FDFE5.3070703@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.