From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfsprog: add mkfs.xfs sb v4 support for dirent filetype field
Date: Thu, 17 Oct 2013 08:26:03 -0500 [thread overview]
Message-ID: <525FE56B.4090302@sgi.com> (raw)
In-Reply-To: <20131016235033.GN4446@dastard>
On 10/16/13 18:50, Dave Chinner wrote:
> On Wed, Oct 16, 2013 at 05:36:57PM -0500, Mark Tinguely wrote:
>> Add directory inode type feature to mkfs.xfs and its manual page.
>>
>> In sb v4, "mkfs.xfs -n ftype=1" turns on the feature. The feature is
>> still automatically turned on for sb v5. Reject the "ftype=1" request
>> if used with the "crc=1" setting.
>>
>> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
>> ---
>> +
>> sbp->sb_features2 = XFS_SB_VERSION2_MKFS(crcs_enabled, lazy_sb_counters,
>> - attrversion == 2, !projid16bit, 0);
>> + attrversion == 2, !projid16bit, 0,
>> + (crcs_enabled && dirftype));
Eek that change was made yesterday and should be:
(!crcs_enabled && dirftype)
so the feature bit is only turned on for v4 sb.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-17 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 22:36 [PATCH 0/3] xfsprogs: v4 inode type in directory Mark Tinguely
2013-10-16 22:36 ` [PATCH 1/3] xfsprog: add xfs sb v4 support for dirent filetype field Mark Tinguely
2013-10-16 22:36 ` [PATCH 2/3] xfsprog: add dirent filetype information for xfs_info Mark Tinguely
2013-10-16 22:36 ` [PATCH 3/3] xfsprog: add mkfs.xfs sb v4 support for dirent filetype field Mark Tinguely
2013-10-16 23:50 ` Dave Chinner
2013-10-17 13:26 ` Mark Tinguely [this message]
2013-10-16 23:54 ` [PATCH 0/3] xfsprogs: v4 inode type in directory Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2013-09-19 21:05 Mark Tinguely
2013-09-19 21:05 ` [PATCH 3/3] xfsprog: add mkfs.xfs sb v4 support for dirent filetype field Mark Tinguely
2013-09-19 23:15 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525FE56B.4090302@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.