From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver. Date: Thu, 17 Oct 2013 15:33:28 +0200 Message-ID: <525FE728.90403@metafoo.de> References: <1382000477-17304-1-git-send-email-Li.Xiubo@freescale.com> <1382000477-17304-2-git-send-email-Li.Xiubo@freescale.com> <525FD4C7.3050806@tabi.org> <525FD65B.3040004@metafoo.de> <525FE48B.7020709@tabi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <525FE48B.7020709@tabi.org> Sender: linux-kernel-owner@vger.kernel.org To: Timur Tabi Cc: Xiubo Li , r65073@freescale.com, lgirdwood@gmail.com, broonie@kernel.org, mark.rutland@arm.com, alsa-devel@alsa-project.org, linux-doc@vger.kernel.org, tiwai@suse.de, b18965@freescale.com, LW@KARO-electronics.de, linux@arm.linux.org.uk, b42378@freescale.com, oskar@scara.com, grant.likely@linaro.org, devicetree@vger.kernel.org, ian.campbell@citrix.com, pawel.moll@arm.com, swarren@wwwdotorg.org, rob.herring@calxeda.com, linux-arm-kernel@lists.infradead.org, fabio.estevam@freescale.com, linux-kernel@vger.kernel.org, rob@landley.net, r64188@freescale.com, shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org List-Id: alsa-devel@alsa-project.org On 10/17/2013 03:22 PM, Timur Tabi wrote: > Lars-Peter Clausen wrote: >>>> >>+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>>> >>+ sai->base = devm_ioremap_resource(&pdev->dev, res); >>> > >>> >Why not use of_iomap()? >> Because it won't check for conflicting resource regions. > > Maybe I've been out of the loop for too long, but why is that a particular > problem with this driver? It is usually something you'd want to check in general to make sure that you don't have multiple device that access the same iomem region at the same time. - Lars From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-233.synserver.de (smtp-out-233.synserver.de [212.40.185.233]) by ozlabs.org (Postfix) with ESMTP id D5FFD2C00CA for ; Fri, 18 Oct 2013 00:31:48 +1100 (EST) Message-ID: <525FE728.90403@metafoo.de> Date: Thu, 17 Oct 2013 15:33:28 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Timur Tabi Subject: Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver. References: <1382000477-17304-1-git-send-email-Li.Xiubo@freescale.com> <1382000477-17304-2-git-send-email-Li.Xiubo@freescale.com> <525FD4C7.3050806@tabi.org> <525FD65B.3040004@metafoo.de> <525FE48B.7020709@tabi.org> In-Reply-To: <525FE48B.7020709@tabi.org> Content-Type: text/plain; charset=ISO-8859-1 Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org, linux-doc@vger.kernel.org, tiwai@suse.de, b18965@freescale.com, linux-kernel@vger.kernel.org, r65073@freescale.com, LW@KARO-electronics.de, linux@arm.linux.org.uk, b42378@freescale.com, Xiubo Li , oskar@scara.com, grant.likely@linaro.org, devicetree@vger.kernel.org, ian.campbell@citrix.com, pawel.moll@arm.com, swarren@wwwdotorg.org, rob.herring@calxeda.com, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, fabio.estevam@freescale.com, lgirdwood@gmail.com, rob@landley.net, r64188@freescale.com, shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/17/2013 03:22 PM, Timur Tabi wrote: > Lars-Peter Clausen wrote: >>>> >>+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>>> >>+ sai->base = devm_ioremap_resource(&pdev->dev, res); >>> > >>> >Why not use of_iomap()? >> Because it won't check for conflicting resource regions. > > Maybe I've been out of the loop for too long, but why is that a particular > problem with this driver? It is usually something you'd want to check in general to make sure that you don't have multiple device that access the same iomem region at the same time. - Lars From mboxrd@z Thu Jan 1 00:00:00 1970 From: lars@metafoo.de (Lars-Peter Clausen) Date: Thu, 17 Oct 2013 15:33:28 +0200 Subject: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver. In-Reply-To: <525FE48B.7020709@tabi.org> References: <1382000477-17304-1-git-send-email-Li.Xiubo@freescale.com> <1382000477-17304-2-git-send-email-Li.Xiubo@freescale.com> <525FD4C7.3050806@tabi.org> <525FD65B.3040004@metafoo.de> <525FE48B.7020709@tabi.org> Message-ID: <525FE728.90403@metafoo.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/17/2013 03:22 PM, Timur Tabi wrote: > Lars-Peter Clausen wrote: >>>> >>+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>>> >>+ sai->base = devm_ioremap_resource(&pdev->dev, res); >>> > >>> >Why not use of_iomap()? >> Because it won't check for conflicting resource regions. > > Maybe I've been out of the loop for too long, but why is that a particular > problem with this driver? It is usually something you'd want to check in general to make sure that you don't have multiple device that access the same iomem region at the same time. - Lars