From: Stefan Weil <sw@weilnetz.de>
To: Tom Musta <tommusta@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <rth@twiddle.net>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
Alexander Graf <agraf@suse.de>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH V2] Fix float64_to_uint64
Date: Thu, 17 Oct 2013 18:31:36 +0200 [thread overview]
Message-ID: <526010E8.8090207@weilnetz.de> (raw)
In-Reply-To: <9D42EDA5-1E37-4E8E-B38C-643CC76D49FB@suse.de>
Am 17.10.2013 11:40, schrieb Alexander Graf:
> On 16.10.2013, at 23:10, Tom Musta <tommusta@gmail.com> wrote:
>
>> The comment preceding the float64_to_uint64 routine suggests that
>> the implementation is broken. And this is, indeed, the case.
>>
>> This patch properly implements the conversion of a 64-bit floating
>> point number to an unsigned, 64 bit integer.
>>
>> Note that the patch does not pass scripts/checkpatch.pl because it
>> maintains the coding style of fpu/softfloat.c.
>>
>> V2: This contribution can be licensed under either the softfloat-2a or -2b
>> license.
> Missing a SoB line.
>
>
> Alex
There is already a mix of coding styles in fpu/softfloat.c, and your
patch adds large regions of new code.
Therefore I expect that such contributions should respect the QEMU
coding style.
The situation is different if only single lines in some function are
replaced or added.
Stefan
next prev parent reply other threads:[~2013-10-17 16:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 14:19 [Qemu-devel] [PATCH] Fix float64_to_uint64 Tom Musta
2013-10-16 20:52 ` Richard Henderson
2013-10-16 21:01 ` Peter Maydell
2013-10-16 21:10 ` [Qemu-devel] [PATCH V2] " Tom Musta
2013-10-17 9:40 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2013-10-17 16:31 ` Stefan Weil [this message]
2013-10-17 17:58 ` Tom Musta
2013-10-18 20:05 ` [Qemu-devel] [V3 PATCH] " Tom Musta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526010E8.8090207@weilnetz.de \
--to=sw@weilnetz.de \
--cc=agraf@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=tommusta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.