From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Arun Kumar K <arun.kk@samsung.com>,
linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org
Cc: hverkuil@xs4all.nl, swarren@wwwdotorg.org, mark.rutland@arm.com,
Pawel.Moll@arm.com, galak@codeaurora.org, a.hajda@samsung.com,
sachin.kamat@linaro.org, shaik.ameer@samsung.com,
kilyeon.im@samsung.com, arunkk.samsung@gmail.com
Subject: Re: [PATCH v9 13/13] V4L: Add driver for s5k4e5 image sensor
Date: Thu, 17 Oct 2013 19:10:08 +0200 [thread overview]
Message-ID: <526019F0.3070406@samsung.com> (raw)
In-Reply-To: <1380279558-21651-14-git-send-email-arun.kk@samsung.com>
On 27/09/13 12:59, Arun Kumar K wrote:
> This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
> Like s5k6a3, it is also another fimc-is firmware controlled
> sensor. This minimal sensor driver doesn't do any I2C communications
> as its done by ISP firmware. It can be updated if needed to a
> regular sensor driver by adding the I2C communication.
>
> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> .../devicetree/bindings/media/i2c/s5k4e5.txt | 45 +++
> drivers/media/i2c/Kconfig | 8 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/s5k4e5.c | 347 ++++++++++++++++++++
> 4 files changed, 401 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
> create mode 100644 drivers/media/i2c/s5k4e5.c
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
> new file mode 100644
> index 0000000..0fca087
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
Could you make a separate patch adding DT binding only ?
And can you please rename this file to:
Documentation/devicetree/bindings/media/samsung-s5k4e5.txt, like
it's done in case of other sensors ?
Should I apply patches 02...11/13 already or would you like send
the whole series updated ? AFAICS there are minor things pointed
out by Hans not addressed yet ?
Regards,
Sylwester
next prev parent reply other threads:[~2013-10-17 17:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 10:59 [PATCH v9 00/13] Exynos5 IS driver Arun Kumar K
2013-09-27 10:59 ` Arun Kumar K
2013-09-27 10:59 ` [PATCH v9 01/13] [media] exynos5-is: Adding media device driver for exynos5 Arun Kumar K
[not found] ` <1380279558-21651-2-git-send-email-arun.kk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-27 21:01 ` Sylwester Nawrocki
2013-09-27 21:01 ` Sylwester Nawrocki
2013-11-11 16:12 ` Mark Rutland
[not found] ` <20131111161213.GK21201-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-11-11 19:25 ` Gerhard Sittig
[not found] ` <20131111192515.GP17929-kDjWylLy9wD0K7fsECOQyeGNnDKD8DIp@public.gmane.org>
2013-11-12 9:54 ` Mark Rutland
2013-09-27 10:59 ` [PATCH v9 02/13] [media] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation Arun Kumar K
2013-11-11 16:19 ` Mark Rutland
2013-09-27 10:59 ` [PATCH v9 03/13] [media] exynos5-fimc-is: Add driver core files Arun Kumar K
2013-09-27 10:59 ` [PATCH v9 06/13] [media] exynos5-fimc-is: Add isp subdev Arun Kumar K
2013-09-27 10:59 ` [PATCH v9 08/13] [media] exynos5-fimc-is: Add sensor interface Arun Kumar K
2013-09-27 10:59 ` [PATCH v9 09/13] [media] exynos5-fimc-is: Add the hardware pipeline control Arun Kumar K
2013-09-30 12:43 ` Hans Verkuil
2013-10-18 4:48 ` Arun Kumar K
[not found] ` <1380279558-21651-1-git-send-email-arun.kk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-27 10:59 ` [PATCH v9 04/13] [media] exynos5-fimc-is: Add common driver header files Arun Kumar K
2013-09-27 10:59 ` Arun Kumar K
2013-09-27 10:59 ` [PATCH v9 05/13] [media] exynos5-fimc-is: Add register definition and context header Arun Kumar K
2013-09-27 10:59 ` Arun Kumar K
2013-09-27 10:59 ` [PATCH v9 07/13] [media] exynos5-fimc-is: Add scaler subdev Arun Kumar K
2013-09-27 10:59 ` Arun Kumar K
2013-09-27 10:59 ` [PATCH v9 10/13] [media] exynos5-fimc-is: Add the hardware interface module Arun Kumar K
2013-09-27 10:59 ` Arun Kumar K
2013-09-27 10:59 ` [PATCH v9 12/13] V4L: s5k6a3: Change sensor min/max resolutions Arun Kumar K
2013-09-27 10:59 ` Arun Kumar K
2013-10-17 17:03 ` Sylwester Nawrocki
2013-10-18 2:45 ` Arun Kumar K
2013-09-27 10:59 ` [PATCH v9 13/13] V4L: Add driver for s5k4e5 image sensor Arun Kumar K
2013-09-27 10:59 ` Arun Kumar K
2013-10-17 17:10 ` Sylwester Nawrocki [this message]
2013-10-18 2:46 ` Arun Kumar K
2013-09-27 10:59 ` [PATCH v9 11/13] [media] exynos5-is: Add Kconfig and Makefile Arun Kumar K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526019F0.3070406@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=Pawel.Moll@arm.com \
--cc=a.hajda@samsung.com \
--cc=arun.kk@samsung.com \
--cc=arunkk.samsung@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=hverkuil@xs4all.nl \
--cc=kilyeon.im@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sachin.kamat@linaro.org \
--cc=shaik.ameer@samsung.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.