From: Tom Musta <tommusta@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <rth@twiddle.net>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
Alexander Graf <agraf@suse.de>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH V2] Fix float64_to_uint64
Date: Thu, 17 Oct 2013 12:58:08 -0500 [thread overview]
Message-ID: <52602530.10800@gmail.com> (raw)
In-Reply-To: <526010E8.8090207@weilnetz.de>
> On 10/17/2013 11:31 AM, Stefan Weil wrote:
>> Am 17.10.2013 11:40, schrieb Alexander Graf:
>> Missing a SoB line.
>>
>>
>> Alex
>
> There is already a mix of coding styles in fpu/softfloat.c, and your
> patch adds large regions of new code.
> Therefore I expect that such contributions should respect the QEMU
> coding style.
>
> The situation is different if only single lines in some function are
> replaced or added.
>
> Stefan
>
OK .... I will rework the patch to use QEMU style. And will add the sob.
next prev parent reply other threads:[~2013-10-17 17:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 14:19 [Qemu-devel] [PATCH] Fix float64_to_uint64 Tom Musta
2013-10-16 20:52 ` Richard Henderson
2013-10-16 21:01 ` Peter Maydell
2013-10-16 21:10 ` [Qemu-devel] [PATCH V2] " Tom Musta
2013-10-17 9:40 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2013-10-17 16:31 ` Stefan Weil
2013-10-17 17:58 ` Tom Musta [this message]
2013-10-18 20:05 ` [Qemu-devel] [V3 PATCH] " Tom Musta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52602530.10800@gmail.com \
--to=tommusta@gmail.com \
--cc=agraf@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.