From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37495)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VWtCl-0006mq-MK
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 15:26:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VWtCg-0001Ug-51
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 15:25:55 -0400
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=46784
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VWtCf-0001Ti-UO
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 15:25:50 -0400
Message-ID: <526039BA.2040509@weilnetz.de>
Date: Thu, 17 Oct 2013 21:25:46 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <CAPM=9txo2k4jMha+u2azexYwTJiJ9ga8kNnPNTJ3Lei7AOa=Yg@mail.gmail.com>
In-Reply-To: <CAPM=9txo2k4jMha+u2azexYwTJiJ9ga8kNnPNTJ3Lei7AOa=Yg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] virtio-blk wierd memcpy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dave Airlie <airlied@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Am 17.10.2013 20:49, schrieb Dave Airlie:
> In my failing attempts to valgrind qemu (how to people live like
> this?), I spotted this in the logs
>
> ==19521== Source and destination overlap in memcpy(0x31d38938, 0x31d38938, 64)
> ==19521==    at 0x4A0A343: memcpy@@GLIBC_2.14 (in
> /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==19521==    by 0x42774E: virtio_blk_device_init (virtio-blk.c:686)
> ==19521==    by 0x46EE9E: virtio_device_init (virtio.c:1158)
> ==19521==    by 0x25405E: device_realize (qdev.c:178)
> ==19521==    by 0x2559B5: device_set_realized (qdev.c:699)
> ==19521==    by 0x3A819B: property_set_bool (object.c:1315)
> ==19521==    by 0x3A6CE0: object_property_set (object.c:803)
>
> The memcpy looks completely superfluous.
>
> Dave.

That's correct - thank you for your report.

I have prepared a patch which removes that memcpy:
http://patchwork.ozlabs.org/patch/284355/

Regards,
Stefan