All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Fehlig <jfehlig@suse.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org, Bamvor Jian Zhang <bjzhang@suse.com>
Subject: Re: [PATCH RFC] improve the error message in "xl list --long"
Date: Thu, 17 Oct 2013 14:38:54 -0600	[thread overview]
Message-ID: <52604ADE.4040305@suse.com> (raw)
In-Reply-To: <21088.7554.778499.91545@mariner.uk.xensource.com>

Ian Jackson wrote:
> Bamvor Jian Zhang writes ("Re: [Xen-devel] [PATCH RFC] improve the error message in "xl list --long""):
>   
>> considering this case, the user use virt-manager for management the virtual
>> machine, he would not aware of xm, xl or virsh is used by virt-manager and
>> vm-install. and it is safe to use the xm with virt-manager because the vm
>> info is only stored in xend not in libvirt. after user migrate from xm to
>> xl, he probably use the similar way. Acctually, our customer report this
>> bug because libvirt libxl driver still missing some apis compare with xl.
>> raising this message could let user know the circumstances.
>>     
>
> Thanks for the explanation.  I'm not sure I entirely follow, so I'm
> going to try to explain in my own words what I think you're saying:
>
> virt-manager users are used to using both xm and virsh to manage
> guests.  After moving to libxl this is even more relevant because of
> missing functionality in the libvirt libxl driver.  However, when a
> user uses xl on domains managed by virsh, things go wrong.  You want
> this to produce a better error message.
>   

I think that is a good summary, as I understand it.

> Is this right ?  If so I think some more details would be helpful to
> know what goes wrong.  It might be possible to make more of this work
> better, or to improve error messages some other way.
>   

A user reported the following when doing a xl long list of a domain
created by libvirt

homevhst01:~ # xl list smt
Name ID Mem VCPUs State Time(s)
smt 1 512 1 -b---- 861.4
homevhst01:~ # xl list --long smt
Domain name must be specified.

Hmm, user did provide a domain name.  This is the error Bamvor is trying
to improve.

> It would be possible in principle to make xl produce a warning when
> operating on a domain not created with xl, by looking for the missing
> userdata.

Yep, sounds reasonable to me.

Regards
Jim

  reply	other threads:[~2013-10-17 20:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17 16:21 [PATCH RFC] improve the error message in "xl list --long" Bamvor Jian Zhang
2013-10-17 16:24 ` Ian Jackson
2013-10-17 16:58   ` Bamvor Jian Zhang
2013-10-17 17:25     ` Ian Jackson
2013-10-17 20:38       ` Jim Fehlig [this message]
2013-10-17 16:25 ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52604ADE.4040305@suse.com \
    --to=jfehlig@suse.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=bjzhang@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.